From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50180)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benh@au1.ibm.com>) id 1XMA35-0001ym-QJ
	for qemu-devel@nongnu.org; Tue, 26 Aug 2014 02:16:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benh@au1.ibm.com>) id 1XMA2t-0005Va-K0
	for qemu-devel@nongnu.org; Tue, 26 Aug 2014 02:16:06 -0400
Received: from e23smtp09.au.ibm.com ([202.81.31.142]:41602)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benh@au1.ibm.com>) id 1XMA2s-0005Uw-Ug
	for qemu-devel@nongnu.org; Tue, 26 Aug 2014 02:15:55 -0400
Received: from /spool/local
	by e23smtp09.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <benh@au1.ibm.com>;
	Tue, 26 Aug 2014 16:15:50 +1000
Message-ID: <1409033740.25772.94.camel@pasglop>
From: Benjamin Herrenschmidt <benh@au1.ibm.com>
Date: Tue, 26 Aug 2014 16:15:40 +1000
In-Reply-To: <20140826053952.GP9923@voom.redhat.com>
References: <20140825134353.2361.52046.stgit@aravindap>
	<20140825134526.2361.74648.stgit@aravindap>
	<20140826053952.GP9923@voom.redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/5] target-ppc: Register and handle HCALL
 to receive updated RTAS region
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: qemu-ppc@nongnu.org, Aravinda Prasad <aravinda@linux.vnet.ibm.com>, aik@au1.ibm.com, qemu-devel@nongnu.org, paulus@samba.org

On Tue, 2014-08-26 at 15:39 +1000, David Gibson wrote:
> On Mon, Aug 25, 2014 at 07:15:26PM +0530, Aravinda Prasad wrote:
> > Receive updates from SLOF about the updated rtas-base.
> > A separate patch for SLOF [1] adds functionality to invoke a
> > a private HCALL whenever OS issues instantiate-rtas with
> > a new rtas-base.
> > 
> > This is required as qemu needs to know the updated rtas-base
> > as it allocates error reporting structure in RTAS space upon
> > a machine check exception.
> 
> This also seems really awkward.  Specifically it seems like a rather
> arbitrary and complex division of what qemu's responsible for and what
> SLOF is responsible for.
> 
> Instead I'd suggest that we add an H_INSTANTIATE_RTAS hcall, and we
> move the loading of the spapr-rtas blob from normal reset to when that
> hcall is invoked.

Beware that SLOF needs to call RTAS for its own reasons...

So it would be instanciated twice.

Cheers,
Ben.