From: Gerd Hoffmann <kraxel@redhat.com>
To: "Gonglei (Arei)" <arei.gonglei@huawei.com>
Cc: "chenliang (T)" <chenliang88@huawei.com>,
"Huangweidong (C)" <weidong.huang@huawei.com>,
"mst@redhat.com" <mst@redhat.com>,
"aik@ozlabs.ru" <aik@ozlabs.ru>,
"hutao@cn.fujitsu.com" <hutao@cn.fujitsu.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"armbru@redhat.com" <armbru@redhat.com>,
"akong@redhat.com" <akong@redhat.com>,
"agraf@suse.de" <agraf@suse.de>,
"aliguori@amazon.com" <aliguori@amazon.com>,
"gaowanlong@cn.fujitsu.com" <gaowanlong@cn.fujitsu.com>,
"ehabkost@redhat.com" <ehabkost@redhat.com>,
Luonengjun <luonengjun@huawei.com>,
"Huangpeng (Peter)" <peter.huangpeng@huawei.com>,
"hani@linux.com" <hani@linux.com>,
"stefanha@redhat.com" <stefanha@redhat.com>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"lcapitulino@redhat.com" <lcapitulino@redhat.com>,
"kwolf@redhat.com" <kwolf@redhat.com>,
"peter.crosthwaite@xilinx.com" <peter.crosthwaite@xilinx.com>,
"imammedo@redhat.com" <imammedo@redhat.com>,
"afaerber@suse.de" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH v5 0/8] modify boot order of guest, and take effect after rebooting
Date: Tue, 26 Aug 2014 12:00:33 +0200 [thread overview]
Message-ID: <1409047233.8727.27.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <33183CC9F5247A488A2544077AF1902086D95E7A@SZXEMA503-MBS.china.huawei.com>
On Di, 2014-08-26 at 09:07 +0000, Gonglei (Arei) wrote:
> Hi, Gerd
>
> Nice to meet you again in maillist. :)
>
> > -----Original Message-----
> > From: Gerd Hoffmann [mailto:kraxel@redhat.com]
> > Sent: Tuesday, August 26, 2014 2:36 PM
> > Subject: Re: [PATCH v5 0/8] modify boot order of guest, and take effect after
> > rebooting
> >
> > > The patchsets add one qmp interface, and add an fw_cfg_machine_reset()
> > > to achieve it.
> >
> > > (qemu) set-bootindex ide0-0-1 1
> > > The bootindex 1 has already been used
> >
> > What happened to the idea to use qom-set instead? I liked that
> > suggestion. Solves the suffix issue in a nice way.
> >
> I have discussed with Makus about qom-set in pervious confabulation.
> The main problem is that qom-set's function is simple, which just change
> a device's property value, but not can do any other logic. In my case,
> I should change global fw_boot_orde for devices's bootindex taking effect.
Two options (also mentioned in the thread):
(1) Set/update bootindex on reset instead of realize/init.
(2) Switch the property from qdev to qom, then use the set
callback to also update the fw_cfg file.
cheers,
Gerd
next prev parent reply other threads:[~2014-08-26 10:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-04 12:46 [Qemu-devel] [PATCH v5 0/8] modify boot order of guest, and take effect after rebooting arei.gonglei
2014-08-04 12:46 ` [Qemu-devel] [PATCH v5 1/8] bootindex: add modify_boot_device_path function arei.gonglei
2014-08-04 12:46 ` [Qemu-devel] [PATCH v5 2/8] bootindex: add del_boot_device_path function arei.gonglei
2014-08-04 12:46 ` [Qemu-devel] [PATCH v5 3/8] fw_cfg: add fw_cfg_machine_reset function arei.gonglei
2014-08-04 12:46 ` [Qemu-devel] [PATCH v5 4/8] bootindex: delete bootindex when device is removed arei.gonglei
2014-08-04 12:46 ` [Qemu-devel] [PATCH v5 5/8] qmp: add set-bootindex command arei.gonglei
2014-08-04 12:46 ` [Qemu-devel] [PATCH v5 6/8] qemu-monitor: HMP set-bootindex wrapper arei.gonglei
2014-08-04 12:46 ` [Qemu-devel] [PATCH v5 7/8] qmp: add query-bootindex command arei.gonglei
2014-08-04 12:46 ` [Qemu-devel] [PATCH v5 8/8] qemu-monitor: add HMP "info-bootindex" command arei.gonglei
2014-08-04 12:53 ` [Qemu-devel] [PATCH v5 0/8] modify boot order of guest, and take effect after rebooting Gonglei (Arei)
2014-08-07 11:50 ` Gonglei (Arei)
2014-08-07 12:57 ` Paolo Bonzini
2014-08-07 13:01 ` Gonglei (Arei)
2014-08-26 6:36 ` Gerd Hoffmann
2014-08-26 9:07 ` Gonglei (Arei)
2014-08-26 10:00 ` Gerd Hoffmann [this message]
2014-08-26 11:24 ` Markus Armbruster
2014-08-27 2:11 ` Gonglei (Arei)
2014-08-27 14:23 ` Gerd Hoffmann
2014-08-28 4:50 ` Gonglei (Arei)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409047233.8727.27.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=akong@redhat.com \
--cc=aliguori@amazon.com \
--cc=arei.gonglei@huawei.com \
--cc=armbru@redhat.com \
--cc=chenliang88@huawei.com \
--cc=ehabkost@redhat.com \
--cc=gaowanlong@cn.fujitsu.com \
--cc=hani@linux.com \
--cc=hutao@cn.fujitsu.com \
--cc=imammedo@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=luonengjun@huawei.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=peter.huangpeng@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=weidong.huang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).