qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Riku Voipio <riku.voipio@iki.fi>,
	Markus Armbruster <armbru@redhat.com>,
	Gerd Hoffmann <kraxel@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Andreas Faerber <afaerber@suse.de>
Subject: [Qemu-devel] [PATCH v2 3/6] trace: avoid Python 2.5 all() in tracetool
Date: Wed, 27 Aug 2014 12:08:53 +0100	[thread overview]
Message-ID: <1409137736-827-4-git-send-email-stefanha@redhat.com> (raw)
In-Reply-To: <1409137736-827-1-git-send-email-stefanha@redhat.com>

Red Hat Enterprise Linux 5 ships Python 2.4.3.  The all() function was
added in Python 2.5 so we cannot use it.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 scripts/tracetool/backend/__init__.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/scripts/tracetool/backend/__init__.py b/scripts/tracetool/backend/__init__.py
index 5bfa1ef..d4b6dab 100644
--- a/scripts/tracetool/backend/__init__.py
+++ b/scripts/tracetool/backend/__init__.py
@@ -102,7 +102,8 @@ class Wrapper:
     def __init__(self, backends, format):
         self._backends = [backend.replace("-", "_") for backend in backends]
         self._format = format.replace("-", "_")
-        assert all(exists(backend) for backend in self._backends)
+        for backend in self._backends:
+            assert exists(backend)
         assert tracetool.format.exists(self._format)
 
     def _run_function(self, name, *args, **kwargs):
-- 
1.9.3

  parent reply	other threads:[~2014-08-27 11:09 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-27 11:08 [Qemu-devel] [PATCH v2 0/6] Fixes for buildbot failures Stefan Hajnoczi
2014-08-27 11:08 ` [Qemu-devel] [PATCH v2 1/6] qapi.py: avoid Python 2.5+ any() function Stefan Hajnoczi
2014-08-27 14:15   ` Benoît Canet
2014-08-27 11:08 ` [Qemu-devel] [PATCH v2 2/6] libqtest: launch QEMU with QEMU_AUDIO_DRV=none Stefan Hajnoczi
2014-08-27 12:58   ` Gerd Hoffmann
2014-08-27 11:08 ` Stefan Hajnoczi [this message]
2014-08-27 14:16   ` [Qemu-devel] [PATCH v2 3/6] trace: avoid Python 2.5 all() in tracetool Benoît Canet
2014-08-27 11:08 ` [Qemu-devel] [PATCH v2 4/6] mirror: fix uninitialized variable delay_ns warnings Stefan Hajnoczi
2014-08-27 14:17   ` Benoît Canet
2014-08-27 11:08 ` [Qemu-devel] [PATCH v2 5/6] block: sort formats alphabetically in bdrv_iterate_format() Stefan Hajnoczi
2014-08-27 14:23   ` Benoît Canet
2014-08-27 11:08 ` [Qemu-devel] [PATCH v2 6/6] Revert "qemu-img: sort block formats in help message" Stefan Hajnoczi
2014-08-27 14:27   ` Benoît Canet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1409137736-827-4-git-send-email-stefanha@redhat.com \
    --to=stefanha@redhat.com \
    --cc=afaerber@suse.de \
    --cc=armbru@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=riku.voipio@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).