qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Richard W.M. Jones" <rjones@redhat.com>
To: qemu-devel@nongnu.org
Cc: stefanha@redhat.com
Subject: [Qemu-devel] [PATCH] curl: Don't deref NULL pointer in call to aio_poll.
Date: Wed, 27 Aug 2014 18:31:26 +0100	[thread overview]
Message-ID: <1409160687-32212-1-git-send-email-rjones@redhat.com> (raw)

The original code in block/curl.c dereferences state *after* checking
that it is NULL.  That's obviously wrong, and indeed I can easily
provoke a segfault when talking to a VMware vCenter server.

I'm not as sure that this fix is the correct one, so please review it
carefully.  However it does at least fix the above segfault.

Rich.

             reply	other threads:[~2014-08-27 17:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-27 17:31 Richard W.M. Jones [this message]
2014-08-27 17:31 ` [Qemu-devel] [PATCH] curl: Don't deref NULL pointer in call to aio_poll Richard W.M. Jones
2014-08-27 21:43   ` Paolo Bonzini
2014-08-28  0:18   ` Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1409160687-32212-1-git-send-email-rjones@redhat.com \
    --to=rjones@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).