From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59080) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMh4O-0000Us-Bw for qemu-devel@nongnu.org; Wed, 27 Aug 2014 13:31:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XMh4G-0001Ho-UQ for qemu-devel@nongnu.org; Wed, 27 Aug 2014 13:31:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52910) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMh4G-0001HW-E4 for qemu-devel@nongnu.org; Wed, 27 Aug 2014 13:31:32 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7RHVUMc008856 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 27 Aug 2014 13:31:31 -0400 From: "Richard W.M. Jones" Date: Wed, 27 Aug 2014 18:31:26 +0100 Message-Id: <1409160687-32212-1-git-send-email-rjones@redhat.com> Subject: [Qemu-devel] [PATCH] curl: Don't deref NULL pointer in call to aio_poll. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: stefanha@redhat.com The original code in block/curl.c dereferences state *after* checking that it is NULL. That's obviously wrong, and indeed I can easily provoke a segfault when talking to a VMware vCenter server. I'm not as sure that this fix is the correct one, so please review it carefully. However it does at least fix the above segfault. Rich.