From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60901) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMhAH-0004El-QY for qemu-devel@nongnu.org; Wed, 27 Aug 2014 13:37:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XMhA7-0003G9-Me for qemu-devel@nongnu.org; Wed, 27 Aug 2014 13:37:45 -0400 Received: from e39.co.us.ibm.com ([32.97.110.160]:45760) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMhA7-0003EN-85 for qemu-devel@nongnu.org; Wed, 27 Aug 2014 13:37:35 -0400 Received: from /spool/local by e39.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 27 Aug 2014 11:37:34 -0600 From: Michael Roth Date: Wed, 27 Aug 2014 12:36:16 -0500 Message-Id: <1409160982-16389-20-git-send-email-mdroth@linux.vnet.ibm.com> In-Reply-To: <1409160982-16389-1-git-send-email-mdroth@linux.vnet.ibm.com> References: <1409160982-16389-1-git-send-email-mdroth@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH 19/25] blkdebug: Delete BH in bdrv_aio_cancel List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org From: Fam Zheng Otherwise error_callback_bh will access the already released acb. Cc: qemu-stable@nongnu.org Signed-off-by: Fam Zheng Signed-off-by: Kevin Wolf (cherry picked from commit cbf95a0b117461473f05ab3cce4d01ba2b29e60a) Signed-off-by: Michael Roth --- block/blkdebug.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/block/blkdebug.c b/block/blkdebug.c index f51407d..01b8e73 100644 --- a/block/blkdebug.c +++ b/block/blkdebug.c @@ -449,6 +449,10 @@ static void error_callback_bh(void *opaque) static void blkdebug_aio_cancel(BlockDriverAIOCB *blockacb) { BlkdebugAIOCB *acb = container_of(blockacb, BlkdebugAIOCB, common); + if (acb->bh) { + qemu_bh_delete(acb->bh); + acb->bh = NULL; + } qemu_aio_release(acb); } -- 1.9.1