From: Max Reitz <mreitz@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Benoît Canet" <benoit.canet@nodalink.com>,
"Max Reitz" <mreitz@redhat.com>
Subject: [Qemu-devel] [PATCH v4 01/10] qcow2: Fix leaks in dirty images
Date: Wed, 27 Aug 2014 22:18:17 +0200 [thread overview]
Message-ID: <1409170706-24465-2-git-send-email-mreitz@redhat.com> (raw)
In-Reply-To: <1409170706-24465-1-git-send-email-mreitz@redhat.com>
When opening dirty images, qcow2's repair function should not only
repair errors but leaks as well.
Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Benoît Canet <benoit.canet@nodalink.com>
---
block/qcow2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index f9e045f..67d6368 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -898,7 +898,7 @@ static int qcow2_open(BlockDriverState *bs, QDict *options, int flags,
(s->incompatible_features & QCOW2_INCOMPAT_DIRTY)) {
BdrvCheckResult result = {0};
- ret = qcow2_check(bs, &result, BDRV_FIX_ERRORS);
+ ret = qcow2_check(bs, &result, BDRV_FIX_ERRORS | BDRV_FIX_LEAKS);
if (ret < 0) {
error_setg_errno(errp, -ret, "Could not repair dirty image");
goto fail;
--
2.1.0
next prev parent reply other threads:[~2014-08-27 20:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-27 20:18 [Qemu-devel] [PATCH v4 00/10] qcow2: Fix image repairing Max Reitz
2014-08-27 20:18 ` Max Reitz [this message]
2014-08-27 20:18 ` [Qemu-devel] [PATCH v4 02/10] qcow2: Split qcow2_check_refcounts() Max Reitz
2014-08-27 20:18 ` [Qemu-devel] [PATCH v4 03/10] qcow2: Pull check_refblocks() up Max Reitz
2014-08-27 20:18 ` [Qemu-devel] [PATCH v4 04/10] qcow2: Reuse refcount table in calculate_refcounts() Max Reitz
2014-08-27 20:18 ` [Qemu-devel] [PATCH v4 05/10] qcow2: Fix refcount blocks beyond image end Max Reitz
2014-08-29 19:50 ` Eric Blake
2014-08-29 19:56 ` Max Reitz
2014-08-27 20:18 ` [Qemu-devel] [PATCH v4 06/10] qcow2: Do not perform potentially damaging repairs Max Reitz
2014-08-27 20:18 ` [Qemu-devel] [PATCH v4 07/10] qcow2: Rebuild refcount structure during check Max Reitz
2014-08-28 16:08 ` Benoît Canet
2014-08-29 19:25 ` Max Reitz
2014-08-27 20:18 ` [Qemu-devel] [PATCH v4 08/10] qcow2: Clean up after refcount rebuild Max Reitz
2014-08-27 20:18 ` [Qemu-devel] [PATCH v4 09/10] iotests: Fix test outputs Max Reitz
2014-08-27 20:18 ` [Qemu-devel] [PATCH v4 10/10] iotests: Add test for potentially damaging repairs Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409170706-24465-2-git-send-email-mreitz@redhat.com \
--to=mreitz@redhat.com \
--cc=benoit.canet@nodalink.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).