From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48619) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMr4g-00089G-Ni for qemu-devel@nongnu.org; Thu, 28 Aug 2014 00:12:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XMr4f-0008Rj-Sb for qemu-devel@nongnu.org; Thu, 28 Aug 2014 00:12:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48265) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMr4f-0008Ra-LP for qemu-devel@nongnu.org; Thu, 28 Aug 2014 00:12:37 -0400 From: Fam Zheng Date: Thu, 28 Aug 2014 12:12:38 +0800 Message-Id: <1409199158-23453-4-git-send-email-famz@redhat.com> In-Reply-To: <1409199158-23453-1-git-send-email-famz@redhat.com> References: <1409199158-23453-1-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH v2 3/3] quorum: Fix leak of opts in quorum_open List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , benoit.canet@irqsave.net, Stefan Hajnoczi Signed-off-by: Fam Zheng Reviewed-by: Beno=C3=AEt Canet --- block/quorum.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/block/quorum.c b/block/quorum.c index 0de07bb..ffe8bd9 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -796,7 +796,7 @@ static int quorum_open(BlockDriverState *bs, QDict *o= ptions, int flags, { BDRVQuorumState *s =3D bs->opaque; Error *local_err =3D NULL; - QemuOpts *opts; + QemuOpts *opts =3D NULL; bool *opened; QDict *sub =3D NULL; QList *list =3D NULL; @@ -908,6 +908,7 @@ close_exit: g_free(s->bs); g_free(opened); exit: + qemu_opts_del(opts); /* propagate error */ if (local_err) { error_propagate(errp, local_err); --=20 2.1.0