From: Gerd Hoffmann <kraxel@redhat.com>
To: Jack Un <jack.un@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Fix OHCI ISO TD state never being written back.
Date: Thu, 28 Aug 2014 10:32:59 +0200 [thread overview]
Message-ID: <1409214779.4812.7.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <1407616476-6181-1-git-send-email-jack.un@gmail.com>
On Sa, 2014-08-09 at 23:34 +0300, Jack Un wrote:
> Hi,
>
> Hope i'm doing this right.
Almost.
> There appears to be typo in OHCI with isochronous transfers
> resulting in isoch. transfer descriptor state never being written back.
> The'put_words' function is in a OR statement hence it is never called.
This patch description should go into the commit message of the patch so
it doesn't get lost when applying the patch. You also don't need a
cover letter for single patches then, just 'git send-email' the patch
as-is.
No need to resend, I've fixed it up this time. Patch added to usb queue.
thanks,
Gerd
prev parent reply other threads:[~2014-08-28 8:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-09 20:34 [Qemu-devel] [PATCH] Fix OHCI ISO TD state never being written back Jack Un
2014-08-09 20:34 ` Jack Un
2014-08-10 2:39 ` Gonglei
2014-08-28 8:32 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409214779.4812.7.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=jack.un@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).