From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54302) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMv8p-0003If-Qr for qemu-devel@nongnu.org; Thu, 28 Aug 2014 04:33:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XMv8j-0002DP-KZ for qemu-devel@nongnu.org; Thu, 28 Aug 2014 04:33:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35112) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMv8j-0002DH-DH for qemu-devel@nongnu.org; Thu, 28 Aug 2014 04:33:05 -0400 Message-ID: <1409214779.4812.7.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Thu, 28 Aug 2014 10:32:59 +0200 In-Reply-To: <1407616476-6181-1-git-send-email-jack.un@gmail.com> References: <1407616476-6181-1-git-send-email-jack.un@gmail.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Fix OHCI ISO TD state never being written back. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jack Un Cc: qemu-devel@nongnu.org On Sa, 2014-08-09 at 23:34 +0300, Jack Un wrote: > Hi, > > Hope i'm doing this right. Almost. > There appears to be typo in OHCI with isochronous transfers > resulting in isoch. transfer descriptor state never being written back. > The'put_words' function is in a OR statement hence it is never called. This patch description should go into the commit message of the patch so it doesn't get lost when applying the patch. You also don't need a cover letter for single patches then, just 'git send-email' the patch as-is. No need to resend, I've fixed it up this time. Patch added to usb queue. thanks, Gerd