qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PULL 4/6] mirror: fix uninitialized variable delay_ns warnings
Date: Thu, 28 Aug 2014 13:44:25 +0100	[thread overview]
Message-ID: <1409229867-16775-5-git-send-email-stefanha@redhat.com> (raw)
In-Reply-To: <1409229867-16775-1-git-send-email-stefanha@redhat.com>

The gcc 4.1.2 compiler warns that delay_ns may be uninitialized in
mirror_iteration().

There are two break statements in the do ... while loop that skip over
the delay_ns assignment.  These are probably the cause of the warning.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 block/mirror.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/block/mirror.c b/block/mirror.c
index 5e7a166..18b18e0 100644
--- a/block/mirror.c
+++ b/block/mirror.c
@@ -157,7 +157,7 @@ static uint64_t coroutine_fn mirror_iteration(MirrorBlockJob *s)
     BlockDriverState *source = s->common.bs;
     int nb_sectors, sectors_per_chunk, nb_chunks;
     int64_t end, sector_num, next_chunk, next_sector, hbitmap_next_sector;
-    uint64_t delay_ns;
+    uint64_t delay_ns = 0;
     MirrorOp *op;
 
     s->sector_num = hbitmap_iter_next(&s->hbi);
@@ -247,8 +247,6 @@ static uint64_t coroutine_fn mirror_iteration(MirrorBlockJob *s)
         next_chunk += added_chunks;
         if (!s->synced && s->common.speed) {
             delay_ns = ratelimit_calculate_delay(&s->limit, added_sectors);
-        } else {
-            delay_ns = 0;
         }
     } while (delay_ns == 0 && next_sector < end);
 
-- 
1.9.3

  parent reply	other threads:[~2014-08-28 12:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-28 12:44 [Qemu-devel] [PULL 0/6] Fixes for buildbot failures Stefan Hajnoczi
2014-08-28 12:44 ` [Qemu-devel] [PULL 1/6] qapi.py: avoid Python 2.5+ any() function Stefan Hajnoczi
2014-08-28 12:44 ` [Qemu-devel] [PULL 2/6] libqtest: launch QEMU with QEMU_AUDIO_DRV=none Stefan Hajnoczi
2014-08-28 12:44 ` [Qemu-devel] [PULL 3/6] trace: avoid Python 2.5 all() in tracetool Stefan Hajnoczi
2014-08-28 12:44 ` Stefan Hajnoczi [this message]
2014-08-28 12:44 ` [Qemu-devel] [PULL 5/6] block: sort formats alphabetically in bdrv_iterate_format() Stefan Hajnoczi
2014-08-28 12:44 ` [Qemu-devel] [PULL 6/6] Revert "qemu-img: sort block formats in help message" Stefan Hajnoczi
2014-08-28 15:07 ` [Qemu-devel] [PULL 0/6] Fixes for buildbot failures Peter Maydell
2014-08-28 15:33 ` Benoît Canet
2014-08-29  9:06   ` Stefan Hajnoczi
2014-08-29  9:32   ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1409229867-16775-5-git-send-email-stefanha@redhat.com \
    --to=stefanha@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).