From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42887) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMz4M-0004F0-Rx for qemu-devel@nongnu.org; Thu, 28 Aug 2014 08:44:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XMz4G-0008CB-Mq for qemu-devel@nongnu.org; Thu, 28 Aug 2014 08:44:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39832) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMz4G-0008C6-Fk for qemu-devel@nongnu.org; Thu, 28 Aug 2014 08:44:44 -0400 From: Stefan Hajnoczi Date: Thu, 28 Aug 2014 13:44:25 +0100 Message-Id: <1409229867-16775-5-git-send-email-stefanha@redhat.com> In-Reply-To: <1409229867-16775-1-git-send-email-stefanha@redhat.com> References: <1409229867-16775-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PULL 4/6] mirror: fix uninitialized variable delay_ns warnings List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell , Stefan Hajnoczi The gcc 4.1.2 compiler warns that delay_ns may be uninitialized in mirror_iteration(). There are two break statements in the do ... while loop that skip over the delay_ns assignment. These are probably the cause of the warning. Signed-off-by: Stefan Hajnoczi --- block/mirror.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/block/mirror.c b/block/mirror.c index 5e7a166..18b18e0 100644 --- a/block/mirror.c +++ b/block/mirror.c @@ -157,7 +157,7 @@ static uint64_t coroutine_fn mirror_iteration(MirrorBlockJob *s) BlockDriverState *source = s->common.bs; int nb_sectors, sectors_per_chunk, nb_chunks; int64_t end, sector_num, next_chunk, next_sector, hbitmap_next_sector; - uint64_t delay_ns; + uint64_t delay_ns = 0; MirrorOp *op; s->sector_num = hbitmap_iter_next(&s->hbi); @@ -247,8 +247,6 @@ static uint64_t coroutine_fn mirror_iteration(MirrorBlockJob *s) next_chunk += added_chunks; if (!s->synced && s->common.speed) { delay_ns = ratelimit_calculate_delay(&s->limit, added_sectors); - } else { - delay_ns = 0; } } while (delay_ns == 0 && next_sector < end); -- 1.9.3