From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, Stefan Weil <sw@weilnetz.de>
Subject: [Qemu-devel] [PULL 10/14] checkpatch.pl: adjust typedef definition to QEMU coding style
Date: Thu, 28 Aug 2014 16:09:09 +0200 [thread overview]
Message-ID: <1409234953-20742-11-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1409234953-20742-1-git-send-email-pbonzini@redhat.com>
Most QEMU typedefs are camelcase, starting with one uppercase letter
and containing at least one lowercase letter. There are a few
all-uppercase types, add the most common too.
This fixes recognition of types in lines such as
static __attribute__((unused)) inline void tcg_out8(TCGContext *s, uint8_t v)
(Example provided by Peter Maydell).
Reported-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>
Cc: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
scripts/checkpatch.pl | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 9d46e5a..053e432 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -206,9 +206,13 @@ our $UTF8 = qr {
| \xF4[\x80-\x8F][\x80-\xBF]{2} # plane 16
}x;
+# There are still some false positives, but this catches most
+# common cases.
our $typeTypedefs = qr{(?x:
- (?:__)?(?:u|s|be|le)(?:8|16|32|64)|
- atomic_t
+ [A-Z][A-Z\d_]*[a-z][A-Za-z\d_]* # camelcase
+ | [A-Z][A-Z\d_]*AIOCB # all uppercase
+ | [A-Z][A-Z\d_]*CPU # all uppercase
+ | QEMUBH # all uppercase
)};
our $logFunctions = qr{(?x:
--
1.8.3.1
next prev parent reply other threads:[~2014-08-28 14:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-28 14:08 [Qemu-devel] [PULL 00/14] KVM changes for 2014-08-28 Paolo Bonzini
2014-08-28 14:09 ` [Qemu-devel] [PULL 01/14] kvm: run cpu state synchronization on target vcpu thread Paolo Bonzini
2014-08-28 14:09 ` [Qemu-devel] [PULL 02/14] cpus: Define callback for QEMU "nmi" command Paolo Bonzini
2014-08-28 14:09 ` [Qemu-devel] [PULL 03/14] s390x: Convert QEMUMachine to MachineClass Paolo Bonzini
2014-08-28 14:09 ` [Qemu-devel] [PULL 04/14] s390x: Migrate to new NMI interface Paolo Bonzini
2014-08-28 14:09 ` [Qemu-devel] [PULL 05/14] spapr: Add support for " Paolo Bonzini
2014-08-28 14:09 ` [Qemu-devel] [PULL 06/14] target-i386: Don't forbid NX bit on PAE PDEs and PTEs Paolo Bonzini
2014-08-28 14:09 ` [Qemu-devel] [PULL 07/14] x86: Use common variable range MTRR counts Paolo Bonzini
2014-08-28 14:09 ` [Qemu-devel] [PULL 08/14] x86: kvm: Add MTRR support for kvm_get|put_msrs() Paolo Bonzini
2014-08-28 14:09 ` [Qemu-devel] [PULL 09/14] x86: Clear MTRRs on vCPU reset Paolo Bonzini
2014-08-28 14:09 ` Paolo Bonzini [this message]
2014-08-28 14:09 ` [Qemu-devel] [PULL 11/14] vl: process -object after other backend options Paolo Bonzini
2014-08-28 14:09 ` [Qemu-devel] [PULL 12/14] target-i386: Add "mpx" CPU feature name Paolo Bonzini
2014-08-28 14:09 ` [Qemu-devel] [PULL 13/14] target-i386: Add "tsc_adjust" " Paolo Bonzini
2014-08-28 14:09 ` [Qemu-devel] [PULL 14/14] mc146818rtc: reinitialize irq_reinject_on_ack_count on reset Paolo Bonzini
2014-08-28 16:07 ` [Qemu-devel] [PULL 00/14] KVM changes for 2014-08-28 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409234953-20742-11-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).