qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-stable@nongnu.org
Subject: [Qemu-devel] [PULL 11/14] vl: process -object after other backend options
Date: Thu, 28 Aug 2014 16:09:10 +0200	[thread overview]
Message-ID: <1409234953-20742-12-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1409234953-20742-1-git-send-email-pbonzini@redhat.com>

QOM backends can refer to chardevs, but not vice versa.  So
process -chardev and -fsdev options before -object

This fixes the rng-egd backend to virtio-rng.

Reported-by: Amos Kong <akong@redhat.com>
Cc: qemu-stable@nongnu.org
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 vl.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/vl.c b/vl.c
index b796c67..95be92d 100644
--- a/vl.c
+++ b/vl.c
@@ -4033,11 +4033,6 @@ int main(int argc, char **argv, char **envp)
         qemu_set_version(machine_class->hw_version);
     }
 
-    if (qemu_opts_foreach(qemu_find_opts("object"),
-                          object_create, NULL, 0) != 0) {
-        exit(1);
-    }
-
     /* Init CPU def lists, based on config
      * - Must be called after all the qemu_read_config_file() calls
      * - Must be called before list_cpus()
@@ -4249,6 +4244,11 @@ int main(int argc, char **argv, char **envp)
         exit(0);
     }
 
+    if (qemu_opts_foreach(qemu_find_opts("object"),
+                          object_create, NULL, 0) != 0) {
+        exit(1);
+    }
+
     machine_opts = qemu_get_machine_opts();
     if (qemu_opt_foreach(machine_opts, object_set_property, current_machine,
                          1) < 0) {
-- 
1.8.3.1

  parent reply	other threads:[~2014-08-28 14:09 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-28 14:08 [Qemu-devel] [PULL 00/14] KVM changes for 2014-08-28 Paolo Bonzini
2014-08-28 14:09 ` [Qemu-devel] [PULL 01/14] kvm: run cpu state synchronization on target vcpu thread Paolo Bonzini
2014-08-28 14:09 ` [Qemu-devel] [PULL 02/14] cpus: Define callback for QEMU "nmi" command Paolo Bonzini
2014-08-28 14:09 ` [Qemu-devel] [PULL 03/14] s390x: Convert QEMUMachine to MachineClass Paolo Bonzini
2014-08-28 14:09 ` [Qemu-devel] [PULL 04/14] s390x: Migrate to new NMI interface Paolo Bonzini
2014-08-28 14:09 ` [Qemu-devel] [PULL 05/14] spapr: Add support for " Paolo Bonzini
2014-08-28 14:09 ` [Qemu-devel] [PULL 06/14] target-i386: Don't forbid NX bit on PAE PDEs and PTEs Paolo Bonzini
2014-08-28 14:09 ` [Qemu-devel] [PULL 07/14] x86: Use common variable range MTRR counts Paolo Bonzini
2014-08-28 14:09 ` [Qemu-devel] [PULL 08/14] x86: kvm: Add MTRR support for kvm_get|put_msrs() Paolo Bonzini
2014-08-28 14:09 ` [Qemu-devel] [PULL 09/14] x86: Clear MTRRs on vCPU reset Paolo Bonzini
2014-08-28 14:09 ` [Qemu-devel] [PULL 10/14] checkpatch.pl: adjust typedef definition to QEMU coding style Paolo Bonzini
2014-08-28 14:09 ` Paolo Bonzini [this message]
2014-08-28 14:09 ` [Qemu-devel] [PULL 12/14] target-i386: Add "mpx" CPU feature name Paolo Bonzini
2014-08-28 14:09 ` [Qemu-devel] [PULL 13/14] target-i386: Add "tsc_adjust" " Paolo Bonzini
2014-08-28 14:09 ` [Qemu-devel] [PULL 14/14] mc146818rtc: reinitialize irq_reinject_on_ack_count on reset Paolo Bonzini
2014-08-28 16:07 ` [Qemu-devel] [PULL 00/14] KVM changes for 2014-08-28 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1409234953-20742-12-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).