qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Lieven <pl@kamp.de>, qemu-stable@nongnu.org
Subject: [Qemu-devel] [PULL 3/8] block/iscsi: fix memory corruption on iscsi resize
Date: Thu, 28 Aug 2014 16:13:20 +0200	[thread overview]
Message-ID: <1409235205-21376-4-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1409235205-21376-1-git-send-email-pbonzini@redhat.com>

From: Peter Lieven <pl@kamp.de>

bs->total_sectors is not yet updated at this point. resulting
in memory corruption if the volume has grown and data is written
to the newly availble areas.

CC: qemu-stable@nongnu.org
Signed-off-by: Peter Lieven <pl@kamp.de>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 block/iscsi.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/block/iscsi.c b/block/iscsi.c
index 2c9cfc1..0bde13d 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -1512,7 +1512,8 @@ static int iscsi_truncate(BlockDriverState *bs, int64_t offset)
     if (iscsilun->allocationmap != NULL) {
         g_free(iscsilun->allocationmap);
         iscsilun->allocationmap =
-            bitmap_new(DIV_ROUND_UP(bs->total_sectors,
+            bitmap_new(DIV_ROUND_UP(sector_lun2qemu(iscsilun->num_blocks,
+                                                    iscsilun),
                                     iscsilun->cluster_sectors));
     }
 
-- 
1.8.3.1

  parent reply	other threads:[~2014-08-28 14:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-28 14:13 [Qemu-devel] [PULL 0/8] SCSI and memory changes for 2014-08-28 Paolo Bonzini
2014-08-28 14:13 ` [Qemu-devel] [PULL 1/8] block: Pass errp in blkconf_geometry Paolo Bonzini
2014-08-28 14:13 ` [Qemu-devel] [PULL 2/8] scsi-bus: Convert DeviceClass init to realize Paolo Bonzini
2014-08-28 14:13 ` Paolo Bonzini [this message]
2014-08-28 14:13 ` [Qemu-devel] [PULL 4/8] scsi-generic: remove superfluous DPRINTF avoid to break compiling Paolo Bonzini
2014-08-28 14:13 ` [Qemu-devel] [PULL 5/8] virtio-scsi: Report error if num_queues is 0 or too large Paolo Bonzini
2014-08-28 14:13 ` [Qemu-devel] [PULL 6/8] xen-hvm: Constify string Paolo Bonzini
2014-08-28 14:13 ` [Qemu-devel] [PULL 7/8] xen: hvm: Abstract away memory region name ref Paolo Bonzini
2014-08-28 14:13 ` [Qemu-devel] [PULL 8/8] memory: Lazy init name from QOM name as needed Paolo Bonzini
2014-08-28 16:56 ` [Qemu-devel] [PULL 0/8] SCSI and memory changes for 2014-08-28 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1409235205-21376-4-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=pl@kamp.de \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).