From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42888) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XN1GS-0001oi-0D for qemu-devel@nongnu.org; Thu, 28 Aug 2014 11:05:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XN1GL-0002mn-Ox for qemu-devel@nongnu.org; Thu, 28 Aug 2014 11:05:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:26753) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XN1GL-0002mh-IL for qemu-devel@nongnu.org; Thu, 28 Aug 2014 11:05:21 -0400 From: "Dr. David Alan Gilbert (git)" Date: Thu, 28 Aug 2014 16:03:56 +0100 Message-Id: <1409238244-31720-40-git-send-email-dgilbert@redhat.com> In-Reply-To: <1409238244-31720-1-git-send-email-dgilbert@redhat.com> References: <1409238244-31720-1-git-send-email-dgilbert@redhat.com> Subject: [Qemu-devel] [PATCH v3 39/47] Add assertion to check migration_dirty_pages List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, amit.shah@redhat.com, lilei@linux.vnet.ibm.com, quintela@redhat.com From: "Dr. David Alan Gilbert" I've seen it go negative once during dev, it shouldn't happen. Signed-off-by: Dr. David Alan Gilbert --- arch_init.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch_init.c b/arch_init.c index d0ee627..d592579 100644 --- a/arch_init.c +++ b/arch_init.c @@ -439,6 +439,7 @@ ram_addr_t migration_bitmap_find_and_reset_dirty(MemoryRegion *mr, if (next < size) { clear_bit(next, migration_bitmap); + assert(migration_dirty_pages > 0); migration_dirty_pages--; } *bitoffset = next; -- 1.9.3