From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40046) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XN3IS-0008EK-96 for qemu-devel@nongnu.org; Thu, 28 Aug 2014 13:15:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XN3IK-0000f3-Lj for qemu-devel@nongnu.org; Thu, 28 Aug 2014 13:15:40 -0400 From: Paolo Bonzini Date: Thu, 28 Aug 2014 19:15:00 +0200 Message-Id: <1409246113-6519-5-git-send-email-pbonzini@redhat.com> In-Reply-To: <1409246113-6519-1-git-send-email-pbonzini@redhat.com> References: <1409246113-6519-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH 04/17] ppc: use ARRAY_SIZE in gdbstub.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: dgibson@redhat.com, qemu-ppc@nongnu.org, tommusta@gmail.com Match the idiom used by linux-user/signal.c and linux-user/elfload.c. Signed-off-by: Paolo Bonzini --- target-ppc/gdbstub.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target-ppc/gdbstub.c b/target-ppc/gdbstub.c index 14675f4..bad49ae 100644 --- a/target-ppc/gdbstub.c +++ b/target-ppc/gdbstub.c @@ -138,7 +138,7 @@ int ppc_cpu_gdb_read_register(CPUState *cs, uint8_t *mem_buf, int n) { uint32_t cr = 0; int i; - for (i = 0; i < 8; i++) { + for (i = 0; i < ARRAY_SIZE(env->crf); i++) { cr |= env->crf[i] << (32 - ((i + 1) * 4)); } gdb_get_reg32(mem_buf, cr); @@ -246,7 +246,7 @@ int ppc_cpu_gdb_write_register(CPUState *cs, uint8_t *mem_buf, int n) { uint32_t cr = ldl_p(mem_buf); int i; - for (i = 0; i < 8; i++) { + for (i = 0; i < ARRAY_SIZE(env->crf); i++) { env->crf[i] = (cr >> (32 - ((i + 1) * 4))) & 0xF; } break; -- 1.8.3.1