From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33046) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XNH3p-0005f7-NZ for qemu-devel@nongnu.org; Fri, 29 Aug 2014 03:57:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XNH3j-0003r3-JY for qemu-devel@nongnu.org; Fri, 29 Aug 2014 03:57:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40514) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XNH3j-0003qz-CW for qemu-devel@nongnu.org; Fri, 29 Aug 2014 03:57:23 -0400 Message-ID: <1409299037.3093.2.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Fri, 29 Aug 2014 09:57:17 +0200 In-Reply-To: <1409297884-18690-1-git-send-email-kraxel@redhat.com> References: <1409297884-18690-1-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qxl-render: add more sanity checks List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Anthony Liguori On Fr, 2014-08-29 at 09:38 +0200, Gerd Hoffmann wrote: > Damn, the dirty rectangle values are signed integers. So the checks > added by commit 788fbf042fc6d5aaeab56757e6dad622ac5f0c21 are not good > enouth, we also have to make sure they are not negative. > > [ Note: There must be something broken in spice-server so we get > negative values in the first place. Bug opened: > https://bugzilla.redhat.com/show_bug.cgi?id=1135372 ] > > Signed-off-by: Gerd Hoffmann > --- > ui/vnc.c | 42 ++++++++++++++++++++++-------------------- > ui/vnc.h | 1 + Oops, scratch that, totally messed up :(