From: Jens Freimann <jfrei@linux.vnet.ibm.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>,
Alexander Graf <agraf@suse.de>,
Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: Jens Freimann <jfrei@linux.vnet.ibm.com>, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 6/7] pc-bios/s390-ccw: Do proper console setup
Date: Fri, 29 Aug 2014 11:01:41 +0200 [thread overview]
Message-ID: <1409302902-57391-7-git-send-email-jfrei@linux.vnet.ibm.com> (raw)
In-Reply-To: <1409302902-57391-1-git-send-email-jfrei@linux.vnet.ibm.com>
From: Christian Borntraeger <borntraeger@de.ibm.com>
The final newline/return must happen before we reset the sclp via
diag 308.
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Reviewed-by: David Hildenbrand <dahi@linux.vnet.ibm.com>
Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Jens Freimann <jfrei@linux.vnet.ibm.com>
---
pc-bios/s390-ccw/bootmap.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/pc-bios/s390-ccw/bootmap.c b/pc-bios/s390-ccw/bootmap.c
index aa1cf80..115d8bb 100644
--- a/pc-bios/s390-ccw/bootmap.c
+++ b/pc-bios/s390-ccw/bootmap.c
@@ -40,11 +40,6 @@ static void jump_to_IPL_2(void)
ResetInfo *current = 0;
void (*ipl)(void) = (void *) (uint64_t) current->ipl_continue;
- debug_print_addr("set IPL addr to", ipl);
-
- /* Ensure the guest output starts fresh */
- sclp_print("\n");
-
*current = save;
ipl(); /* should not return */
}
@@ -64,6 +59,11 @@ static void jump_to_IPL_code(uint64_t address)
current->ipl_addr = (uint32_t) (uint64_t) &jump_to_IPL_2;
current->ipl_continue = address & 0x7fffffff;
+ debug_print_int("set IPL addr to", current->ipl_continue);
+
+ /* Ensure the guest output starts fresh */
+ sclp_print("\n");
+
/*
* HACK ALERT.
* We use the load normal reset to keep r15 unchanged. jump_to_IPL_2
--
1.8.5.5
next prev parent reply other threads:[~2014-08-29 9:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-29 9:01 [Qemu-devel] [PATCH 0/7] s390-ccw.img: block size and DASD format support Jens Freimann
2014-08-29 9:01 ` [Qemu-devel] [PATCH 1/7] pc-bios/s390-ccw: support all virtio block size Jens Freimann
2014-08-29 9:01 ` [Qemu-devel] [PATCH 2/7] pc-bios/s390-ccw: handle more ECKD DASD block sizes Jens Freimann
2014-08-29 9:01 ` [Qemu-devel] [PATCH 3/7] pc-bios/s390-ccw Improve ECKD informational message Jens Freimann
2014-08-29 9:01 ` [Qemu-devel] [PATCH 4/7] pc-bios/s390-ccw Really big EAV ECKD DASD handling Jens Freimann
2014-08-29 9:01 ` [Qemu-devel] [PATCH 5/7] pc-bios/s390-ccw: IPL from DASD with format variations Jens Freimann
2014-08-29 9:01 ` Jens Freimann [this message]
2014-08-29 9:01 ` [Qemu-devel] [PATCH 7/7] pc-bios/s390-ccw.img binary update Jens Freimann
2014-08-29 10:10 ` [Qemu-devel] [PATCH 0/7] s390-ccw.img: block size and DASD format support Christian Borntraeger
2014-09-05 23:26 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409302902-57391-7-git-send-email-jfrei@linux.vnet.ibm.com \
--to=jfrei@linux.vnet.ibm.com \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).