* [Qemu-devel] [PATCH] hw/arm/virt: add linux, stdout-path to /chosen DT node
@ 2014-08-29 13:03 Ard Biesheuvel
2014-08-29 15:06 ` Rob Herring
2014-09-01 15:55 ` Peter Maydell
0 siblings, 2 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2014-08-29 13:03 UTC (permalink / raw)
To: qemu-devel, peter.maydell, rob.herring; +Cc: Ard Biesheuvel
Add a property "linux,stdout-path" to the /chosen DT node and make
it point to the emulated UART. This allows users such as the Linux
kernel to produce console output without the need to pass console=
or earlycon=pl011,0x... command line arguments.
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
hw/arm/virt.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index 0edc1fa6cb22..619660a011b0 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -377,6 +377,8 @@ static void create_uart(const VirtBoardInfo *vbi, qemu_irq *pic)
vbi->clock_phandle, vbi->clock_phandle);
qemu_fdt_setprop(vbi->fdt, nodename, "clock-names",
clocknames, sizeof(clocknames));
+
+ qemu_fdt_setprop_string(vbi->fdt, "/chosen", "linux,stdout-path", nodename);
g_free(nodename);
}
--
1.8.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] hw/arm/virt: add linux, stdout-path to /chosen DT node
2014-08-29 13:03 [Qemu-devel] [PATCH] hw/arm/virt: add linux, stdout-path to /chosen DT node Ard Biesheuvel
@ 2014-08-29 15:06 ` Rob Herring
2014-09-01 15:55 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2014-08-29 15:06 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: Peter Maydell, QEMU Developers
On Fri, Aug 29, 2014 at 8:03 AM, Ard Biesheuvel
<ard.biesheuvel@linaro.org> wrote:
> Add a property "linux,stdout-path" to the /chosen DT node and make
> it point to the emulated UART. This allows users such as the Linux
> kernel to produce console output without the need to pass console=
> or earlycon=pl011,0x... command line arguments.
>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
I have this same patch in my tree. BTW, you do still need just
"earlycon" on the command-line to get an early console.
Reviewed-by: Rob Herring <rob.herring@linaro.org>
Rob
> ---
> hw/arm/virt.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index 0edc1fa6cb22..619660a011b0 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -377,6 +377,8 @@ static void create_uart(const VirtBoardInfo *vbi, qemu_irq *pic)
> vbi->clock_phandle, vbi->clock_phandle);
> qemu_fdt_setprop(vbi->fdt, nodename, "clock-names",
> clocknames, sizeof(clocknames));
> +
> + qemu_fdt_setprop_string(vbi->fdt, "/chosen", "linux,stdout-path", nodename);
> g_free(nodename);
> }
>
> --
> 1.8.3.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/arm/virt: add linux, stdout-path to /chosen DT node
2014-08-29 13:03 [Qemu-devel] [PATCH] hw/arm/virt: add linux, stdout-path to /chosen DT node Ard Biesheuvel
2014-08-29 15:06 ` Rob Herring
@ 2014-09-01 15:55 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2014-09-01 15:55 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: Rob Herring, QEMU Developers
On 29 August 2014 14:03, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
> Add a property "linux,stdout-path" to the /chosen DT node and make
> it point to the emulated UART. This allows users such as the Linux
> kernel to produce console output without the need to pass console=
> or earlycon=pl011,0x... command line arguments.
>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> hw/arm/virt.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index 0edc1fa6cb22..619660a011b0 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -377,6 +377,8 @@ static void create_uart(const VirtBoardInfo *vbi, qemu_irq *pic)
> vbi->clock_phandle, vbi->clock_phandle);
> qemu_fdt_setprop(vbi->fdt, nodename, "clock-names",
> clocknames, sizeof(clocknames));
> +
> + qemu_fdt_setprop_string(vbi->fdt, "/chosen", "linux,stdout-path", nodename);
> g_free(nodename);
> }
Applied to target-arm.next, thanks.
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-09-01 15:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-29 13:03 [Qemu-devel] [PATCH] hw/arm/virt: add linux, stdout-path to /chosen DT node Ard Biesheuvel
2014-08-29 15:06 ` Rob Herring
2014-09-01 15:55 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).