From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Michael Mueller" <mimu@linux.vnet.ibm.com>,
"Marcel Apfelbaum" <marcel.a@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Alexander Graf" <agraf@suse.de>,
"Christian Borntraeger" <borntraeger@de.ibm.com>,
"Jason J. Herne" <jjherne@linux.vnet.ibm.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: [Qemu-devel] [PATCH v2 07/17] accel: Make AccelClass.available() optional
Date: Fri, 29 Aug 2014 17:31:40 -0300 [thread overview]
Message-ID: <1409344310-5441-8-git-send-email-ehabkost@redhat.com> (raw)
In-Reply-To: <1409344310-5441-1-git-send-email-ehabkost@redhat.com>
When we move accel classes outside accel.c, the available() function
won't be necessary anymore, because the classes will be registered only
if the accelerator code is really enabled at build time.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
hw/core/accel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/core/accel.c b/hw/core/accel.c
index 01cdbc3..483bbe8 100644
--- a/hw/core/accel.c
+++ b/hw/core/accel.c
@@ -82,7 +82,7 @@ int configure_accelerator(MachineClass *mc)
fprintf(stderr, "\"%s\" accelerator does not exist.\n", buf);
continue;
}
- if (!acc->available()) {
+ if (acc->available && !acc->available()) {
printf("%s not supported for this target\n",
acc->name);
continue;
--
1.9.3
next prev parent reply other threads:[~2014-08-29 20:32 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-29 20:31 [Qemu-devel] [PATCH v2 00/17] QOMify accelerator code Eduardo Habkost
2014-08-29 20:31 ` [Qemu-devel] [PATCH v2 01/17] vl.c: Small coding style fix Eduardo Habkost
2014-09-26 15:11 ` Paolo Bonzini
2014-08-29 20:31 ` [Qemu-devel] [PATCH v2 02/17] accel: Move accel code to accel.c Eduardo Habkost
2014-09-26 15:00 ` Paolo Bonzini
2014-08-29 20:31 ` [Qemu-devel] [PATCH v2 03/17] accel: Create AccelType typedef Eduardo Habkost
2014-09-26 15:00 ` Paolo Bonzini
2014-08-29 20:31 ` [Qemu-devel] [PATCH v2 04/17] accel: Simplify configure_accelerator() using AccelType *acc variable Eduardo Habkost
2014-09-26 15:00 ` Paolo Bonzini
2014-08-29 20:31 ` [Qemu-devel] [PATCH v2 05/17] accel: Move accel name lookup to separate function Eduardo Habkost
2014-09-26 15:01 ` Paolo Bonzini
2014-08-29 20:31 ` [Qemu-devel] [PATCH v2 06/17] accel: Use QOM classes for accel types Eduardo Habkost
2014-09-26 15:02 ` Paolo Bonzini
2014-08-29 20:31 ` Eduardo Habkost [this message]
2014-09-26 15:02 ` [Qemu-devel] [PATCH v2 07/17] accel: Make AccelClass.available() optional Paolo Bonzini
2014-08-29 20:31 ` [Qemu-devel] [PATCH v2 08/17] accel: Move KVM accel registration to kvm-all.c Eduardo Habkost
2014-09-26 15:03 ` Paolo Bonzini
2014-09-26 15:03 ` Paolo Bonzini
2014-08-29 20:31 ` [Qemu-devel] [PATCH v2 09/17] accel: Move Xen registration code to xen-common.c Eduardo Habkost
2014-09-26 15:04 ` Paolo Bonzini
2014-08-29 20:31 ` [Qemu-devel] [PATCH v2 10/17] accel: Move qtest accel registration to qtest.c Eduardo Habkost
2014-09-26 15:04 ` Paolo Bonzini
2014-09-26 15:06 ` Paolo Bonzini
2014-09-26 19:37 ` Eduardo Habkost
2014-08-29 20:31 ` [Qemu-devel] [PATCH v2 11/17] accel: Remove tcg_available() function Eduardo Habkost
2014-09-26 15:05 ` Paolo Bonzini
2014-08-29 20:31 ` [Qemu-devel] [PATCH v2 12/17] accel: Move accel init/allowed code to separate function Eduardo Habkost
2014-09-26 15:05 ` Paolo Bonzini
2014-08-29 20:31 ` [Qemu-devel] [PATCH v2 13/17] accel: Rename 'init' method to 'init_machine' Eduardo Habkost
2014-09-26 15:09 ` Paolo Bonzini
2014-09-26 16:42 ` Eduardo Habkost
2014-08-29 20:31 ` [Qemu-devel] [PATCH v2 14/17] accel: Pass MachineState object to accel init functions Eduardo Habkost
2014-09-26 15:10 ` Paolo Bonzini
2014-08-29 20:31 ` [Qemu-devel] [PATCH v2 15/17] accel: Create accel object when initializing machine Eduardo Habkost
2014-09-26 15:10 ` Paolo Bonzini
2014-08-29 20:31 ` [Qemu-devel] [PATCH v2 16/17] accel: Save AccelState on MachineState when initializing Eduardo Habkost
2014-09-26 15:11 ` Paolo Bonzini
2014-08-29 20:31 ` [Qemu-devel] [PATCH v2 17/17] kvm: Make KVMState be the TYPE_KVM_ACCEL instance struct Eduardo Habkost
2014-09-26 15:11 ` Paolo Bonzini
2014-09-26 15:12 ` [Qemu-devel] [PATCH v2 00/17] QOMify accelerator code Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409344310-5441-8-git-send-email-ehabkost@redhat.com \
--to=ehabkost@redhat.com \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=jjherne@linux.vnet.ibm.com \
--cc=marcel.a@redhat.com \
--cc=mimu@linux.vnet.ibm.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).