From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37411) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XNTvX-0007WP-W0 for qemu-devel@nongnu.org; Fri, 29 Aug 2014 17:41:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XNTvS-0008FW-LZ for qemu-devel@nongnu.org; Fri, 29 Aug 2014 17:41:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36624) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XNTvS-0008FH-56 for qemu-devel@nongnu.org; Fri, 29 Aug 2014 17:41:42 -0400 From: Max Reitz Date: Fri, 29 Aug 2014 23:41:01 +0200 Message-Id: <1409348463-16627-10-git-send-email-mreitz@redhat.com> In-Reply-To: <1409348463-16627-1-git-send-email-mreitz@redhat.com> References: <1409348463-16627-1-git-send-email-mreitz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH v5 09/11] qcow2: Clean up after refcount rebuild List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi , =?UTF-8?q?Beno=C3=AEt=20Canet?= , Max Reitz Because the old refcount structure will be leaked after having rebuilt it, we need to recalculate the refcounts and run a leak-fixing operation afterwards (if leaks should be fixed at all). Signed-off-by: Max Reitz Reviewed-by: Beno=C3=AEt Canet --- block/qcow2-refcount.c | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c index 318c152..29136ee 100644 --- a/block/qcow2-refcount.c +++ b/block/qcow2-refcount.c @@ -1907,12 +1907,47 @@ int qcow2_check_refcounts(BlockDriverState *bs, B= drvCheckResult *res, nb_clusters); =20 if (rebuild && (fix & BDRV_FIX_ERRORS)) { + BdrvCheckResult old_res =3D *res; + fprintf(stderr, "Rebuilding refcount structure\n"); ret =3D rebuild_refcount_structure(bs, res, &refcount_table, &nb_clusters); if (ret < 0) { goto fail; } + + res->corruptions =3D 0; + res->leaks =3D 0; + + /* Because the old reftable has been exchanged for a new one the + * references have to be recalculated */ + rebuild =3D false; + memset(refcount_table, 0, nb_clusters * sizeof(uint16_t)); + ret =3D calculate_refcounts(bs, res, 0, &rebuild, &refcount_tabl= e, + &nb_clusters); + if (ret < 0) { + goto fail; + } + + if (fix & BDRV_FIX_LEAKS) { + /* The old refcount structures are now leaked, fix it; the r= esult + * can be ignored */ + pre_compare_res =3D *res; + compare_refcounts(bs, res, BDRV_FIX_LEAKS, &rebuild, + &highest_cluster, refcount_table, nb_clust= ers); + if (rebuild) { + fprintf(stderr, "ERROR rebuilt refcount structure is sti= ll " + "broken\n"); + } + *res =3D pre_compare_res; + } + + if (res->corruptions < old_res.corruptions) { + res->corruptions_fixed +=3D old_res.corruptions - res->corru= ptions; + } + if (res->leaks < old_res.leaks) { + res->leaks_fixed +=3D old_res.leaks - res->leaks; + } } else if (fix) { if (rebuild) { fprintf(stderr, "ERROR need to rebuild refcount structures\n= "); --=20 2.1.0