From: Max Reitz <mreitz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Max Reitz <mreitz@redhat.com>
Subject: [Qemu-devel] [PATCH 0/2] qcow2: Drop REFCOUNT_SHIFT
Date: Fri, 29 Aug 2014 23:45:25 +0200 [thread overview]
Message-ID: <1409348727-17183-1-git-send-email-mreitz@redhat.com> (raw)
In preparation for qemu maybe actually supporting variable refcount
widths in the far future, drop the hardcoded REFCOUNT_SHIFT and instead
use the value as given by the image.
Also, the qcow2 documentation gave the width of a refcount block entry
as sizeof(uint16_t), which is wrong for any refcount order other than 4.
Fix that.
This is a follow-up to my "[PATCH v5 00/11] qcow2: Fix image repairing"
series and therefore depends on it.
Max Reitz (2):
qcow2: Drop REFCOUNT_SHIFT
docs/qcow2: Correct refcount_block_entries
block/qcow2-refcount.c | 32 ++++++++++++++------------------
block/qcow2.c | 2 +-
block/qcow2.h | 2 --
docs/specs/qcow2.txt | 2 +-
4 files changed, 16 insertions(+), 22 deletions(-)
--
2.1.0
next reply other threads:[~2014-08-29 21:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-29 21:45 Max Reitz [this message]
2014-08-29 21:45 ` [Qemu-devel] [PATCH 1/2] qcow2: Drop REFCOUNT_SHIFT Max Reitz
2014-08-29 23:06 ` Eric Blake
2014-09-01 11:17 ` Benoît Canet
2014-08-29 21:45 ` [Qemu-devel] [PATCH 2/2] docs/qcow2: Correct refcount_block_entries Max Reitz
2014-08-29 22:37 ` Eric Blake
2014-09-02 18:59 ` Max Reitz
2014-09-02 19:33 ` Eric Blake
2014-09-01 10:55 ` Benoît Canet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409348727-17183-1-git-send-email-mreitz@redhat.com \
--to=mreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).