[Qemu-devel] [PATCH] numa: fix qerror_report_err not free issue

[Qemu-devel] [PATCH] numa: fix qerror_report_err not free issue

[john.liuli]

From: Li Liu <john.liuli@huawei.com>

All qerror_report_err returned none NULL pointers need to
be freed, otherwise will cause memory leaking.

Although this place did not cause real memory leaking by exit,
obviously it's not correct to use qerror_report_err
without error_free it.

Signed-off-by: Li Liu <john.liuli@huawei.com>
---
 numa.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/numa.c b/numa.c
index c78cec9..0b4ac9b 100644
--- a/numa.c
+++ b/numa.c
@@ -298,6 +298,7 @@ void memory_region_allocate_system_memory(MemoryRegion *mr, Object *owner,
         MemoryRegion *seg = host_memory_backend_get_memory(backend, &local_err);
         if (local_err) {
             qerror_report_err(local_err);
+            error_free(local_err);
             exit(1);
         }
 
-- 
1.7.9.5

Re: [Qemu-devel] [PATCH] numa: fix qerror_report_err not free issue

[Michael Tokarev]

30.08.2014 07:36, john.liuli wrote:
> From: Li Liu <john.liuli@huawei.com>
> 
> All qerror_report_err returned none NULL pointers need to
> be freed, otherwise will cause memory leaking.
> 
> Although this place did not cause real memory leaking by exit,
> obviously it's not correct to use qerror_report_err
> without error_free it.

I don't thing there's any good reason to free resources like
this (freeing memory, closing files, etc) right before exit()
(esp. in error path).  The OS will do that for us in one go
much faster.

/mjt

Re: [Qemu-devel] [PATCH] numa: fix qerror_report_err not free issue

[Gonglei (Arei)]

> -----Original Message-----
> From: qemu-devel-bounces+arei.gonglei=huawei.com@nongnu.org
> [mailto:qemu-devel-bounces+arei.gonglei=huawei.com@nongnu.org] On
> Behalf Of Michael Tokarev
> Sent: Saturday, August 30, 2014 1:26 PM
> To: Liuli (I)
> Cc: qemu-trivial@nongnu.org; qemu-devel@nongnu.org
> Subject: Re: [Qemu-devel] [PATCH] numa: fix qerror_report_err not free issue
> 
> 30.08.2014 07:36, john.liuli wrote:
> > From: Li Liu <john.liuli@huawei.com>
> >
> > All qerror_report_err returned none NULL pointers need to
> > be freed, otherwise will cause memory leaking.
> >
> > Although this place did not cause real memory leaking by exit,
> > obviously it's not correct to use qerror_report_err
> > without error_free it.
> 
> I don't thing there's any good reason to free resources like
> this (freeing memory, closing files, etc) right before exit()
> (esp. in error path).  The OS will do that for us in one go
> much faster.
> 
Yes. Agreed.

Best regards,
-Gonglei

Re: [Qemu-devel] [PATCH] numa: fix qerror_report_err not free issue

[Li Liu]

On 2014/8/30 13:26, Michael Tokarev wrote:
> 30.08.2014 07:36, john.liuli wrote:
>> From: Li Liu <john.liuli@huawei.com>
>>
>> All qerror_report_err returned none NULL pointers need to
>> be freed, otherwise will cause memory leaking.
>>
>> Although this place did not cause real memory leaking by exit,
>> obviously it's not correct to use qerror_report_err
>> without error_free it.
> 
> I don't thing there's any good reason to free resources like
> this (freeing memory, closing files, etc) right before exit()
> (esp. in error path).  The OS will do that for us in one go
> much faster.
> 

Yes, the OS will do that for us. But if someone refer to this code
to use qerror_report_err, it will give a bad hint. Of cause this
patch is just a suggestion.

Best regards
Li.

> /mjt
> 
>