From: Chrysostomos Nanakos <cnanakos@grnet.gr>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, pbonzini@redhat.com,
Chrysostomos Nanakos <cnanakos@grnet.gr>,
stefanha@redhat.com
Subject: [Qemu-devel] [PATCH v1 2/2] block/archipelago: Use QEMU atomic builtins
Date: Mon, 1 Sep 2014 11:58:41 +0300 [thread overview]
Message-ID: <1409561921-4049-2-git-send-email-cnanakos@grnet.gr> (raw)
In-Reply-To: <1409561921-4049-1-git-send-email-cnanakos@grnet.gr>
Replace __sync builtins with the ones provided by QEMU
for atomic operations.
Signed-off-by: Chrysostomos Nanakos <cnanakos@grnet.gr>
---
block/archipelago.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/block/archipelago.c b/block/archipelago.c
index 34f72dc..fa8cd29 100644
--- a/block/archipelago.c
+++ b/block/archipelago.c
@@ -57,6 +57,7 @@
#include "qapi/qmp/qint.h"
#include "qapi/qmp/qstring.h"
#include "qapi/qmp/qjson.h"
+#include "qemu/atomic.h"
#include <inttypes.h>
#include <xseg/xseg.h>
@@ -214,7 +215,7 @@ static void xseg_request_handler(void *state)
xseg_put_request(s->xseg, req, s->srcport);
- if ((__sync_add_and_fetch(&segreq->ref, -1)) == 0) {
+ if ((atomic_add_fetch(&segreq->ref, -1)) == 0) {
if (!segreq->failed) {
reqdata->aio_cb->ret = segreq->count;
archipelago_finish_aiocb(reqdata);
@@ -233,7 +234,7 @@ static void xseg_request_handler(void *state)
segreq->count += req->serviced;
xseg_put_request(s->xseg, req, s->srcport);
- if ((__sync_add_and_fetch(&segreq->ref, -1)) == 0) {
+ if ((atomic_add_fetch(&segreq->ref, -1)) == 0) {
if (!segreq->failed) {
reqdata->aio_cb->ret = segreq->count;
archipelago_finish_aiocb(reqdata);
@@ -885,13 +886,13 @@ static int archipelago_aio_segmented_rw(BDRVArchipelagoState *s,
return 0;
err_exit:
- __sync_add_and_fetch(&segreq->failed, 1);
+ atomic_add_fetch(&segreq->failed, 1);
if (segments_nr == 1) {
- if (__sync_add_and_fetch(&segreq->ref, -1) == 0) {
+ if (atomic_add_fetch(&segreq->ref, -1) == 0) {
g_free(segreq);
}
} else {
- if ((__sync_add_and_fetch(&segreq->ref, -segments_nr + i)) == 0) {
+ if ((atomic_add_fetch(&segreq->ref, -segments_nr + i)) == 0) {
g_free(segreq);
}
}
--
1.7.10.4
next prev parent reply other threads:[~2014-09-01 9:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-01 8:58 [Qemu-devel] [PATCH v1 1/2] Extend header file for atomic operations Chrysostomos Nanakos
2014-09-01 8:58 ` Chrysostomos Nanakos [this message]
2014-09-01 9:43 ` [Qemu-devel] [PATCH v1 2/2] block/archipelago: Use QEMU atomic builtins Paolo Bonzini
2014-09-01 10:13 ` Chrysostomos Nanakos
2014-09-01 10:33 ` Paolo Bonzini
2014-09-01 10:39 ` Chrysostomos Nanakos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409561921-4049-2-git-send-email-cnanakos@grnet.gr \
--to=cnanakos@grnet.gr \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).