From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42072) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XOktw-00081T-Ej for qemu-devel@nongnu.org; Tue, 02 Sep 2014 06:01:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XOkto-0006bO-98 for qemu-devel@nongnu.org; Tue, 02 Sep 2014 06:01:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57694) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XOkto-0006bB-1Z for qemu-devel@nongnu.org; Tue, 02 Sep 2014 06:01:16 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s82A1E8w022079 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 2 Sep 2014 06:01:15 -0400 From: Stefan Hajnoczi Date: Tue, 2 Sep 2014 11:01:03 +0100 Message-Id: <1409652063-32336-3-git-send-email-stefanha@redhat.com> In-Reply-To: <1409652063-32336-1-git-send-email-stefanha@redhat.com> References: <1409652063-32336-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PATCH v2 2/2] qemu-img: fix rebase src_cache option documentation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , jenelson@redhat.com, Fam Zheng , Stefan Hajnoczi , Max Reitz The src_cache option (-T) specifies the cache mode for backing files. It applies both the image's old backing file as well as the new backing file: ret = bdrv_open(&bs_old_backing, backing_name, NULL, NULL, src_flags, old_backing_drv, &local_err); if (ret) { ... } if (out_baseimg[0]) { bs_new_backing = bdrv_new("new_backing", &error_abort); ret = bdrv_open(&bs_new_backing, out_baseimg, NULL, NULL, src_flags, new_backing_drv, &local_err); if (ret) { ... } } The documentation only mentions the new backing file but it really applies to both. Suggested-by: Jeff Nelson Signed-off-by: Stefan Hajnoczi --- qemu-img.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-img.texi b/qemu-img.texi index 4380d56..cc4668e 100644 --- a/qemu-img.texi +++ b/qemu-img.texi @@ -341,7 +341,7 @@ string), then the image is rebased onto no backing file (i.e. it will exist independently of any backing file). @var{cache} specifies the cache mode to be used for @var{filename}, whereas -@var{src_cache} specifies the cache mode for reading the new backing file. +@var{src_cache} specifies the cache mode for reading backing files. There are two different modes in which @code{rebase} can operate: @table @option -- 1.9.3