qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: Markus Armbruster <armbru@redhat.com>,
	Anthony Liguori <aliguori@amazon.com>,
	patches@linaro.org
Subject: [Qemu-devel] [PATCH v2 0/5] Convert remaining legacy chardevs to QAPI
Date: Tue,  2 Sep 2014 11:24:12 +0100	[thread overview]
Message-ID: <1409653457-27863-1-git-send-email-peter.maydell@linaro.org> (raw)

This patchset converts the two remaining legacy chardevs
('socket' and 'udp') to use the new-style parse/kind
mechanisms, and removes all the no-longer-required
legacy machinery.

Patch 1 was posted to the list back in June
(https://patches.linaro.org/32298/). I've fixed the obvious
bug picked up in code review, and as far as I can tell from
the thread we decided that the blocking/non-blocking
difference between QAPI and legacy wasn't a problem.

Patch 2 fixes a hole in the functionality of QAPI-described
UDP chardevs, to avoid regressing the commandline functionality
when we convert the UDP backend in patch 3.

Patch 4 may be easier to review as an ignore-whitespaces
diff (the de-indentation makes the diff a bit awkward).

Changes v1->v2:
 * fixed the has_* values as suggested by Markus
 * added patch 5 which renames the _qapi() function now
   the legacy version has gone (again, as suggested by
   Markus)

Peter Maydell (5):
  qemu-char: Convert socket backend to QAPI
  util/qemu-sockets.c: Support specifying IPv4 or IPv6 in socket_dgram()
  qemu-char: Convert udp backend to QAPI
  qemu-char: Remove register_char_driver() machinery
  qemu-char: Rename register_char_driver_qapi() to
    register_char_driver()

 backends/baum.c       |   2 +-
 backends/msmouse.c    |   2 +-
 backends/testdev.c    |   2 +-
 include/sysemu/char.h |   3 +-
 qemu-char.c           | 353 ++++++++++++++++++++++++--------------------------
 spice-qemu-char.c     |   8 +-
 ui/console.c          |   3 +-
 util/qemu-sockets.c   |   3 +-
 8 files changed, 180 insertions(+), 196 deletions(-)

-- 
1.9.1

             reply	other threads:[~2014-09-02 10:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-02 10:24 Peter Maydell [this message]
2014-09-02 10:24 ` [Qemu-devel] [PATCH v2 1/5] qemu-char: Convert socket backend to QAPI Peter Maydell
2014-09-02 10:24 ` [Qemu-devel] [PATCH v2 2/5] util/qemu-sockets.c: Support specifying IPv4 or IPv6 in socket_dgram() Peter Maydell
2014-09-02 10:24 ` [Qemu-devel] [PATCH v2 3/5] qemu-char: Convert udp backend to QAPI Peter Maydell
2014-09-02 20:04   ` Eric Blake
2014-09-02 20:30     ` Peter Maydell
2014-09-02 10:24 ` [Qemu-devel] [PATCH v2 4/5] qemu-char: Remove register_char_driver() machinery Peter Maydell
2014-09-02 10:24 ` [Qemu-devel] [PATCH v2 5/5] qemu-char: Rename register_char_driver_qapi() to register_char_driver() Peter Maydell
2014-09-09  6:47 ` [Qemu-devel] [PATCH v2 0/5] Convert remaining legacy chardevs to QAPI Paolo Bonzini
2014-09-09  8:11   ` Peter Maydell
2014-09-16 23:43     ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1409653457-27863-1-git-send-email-peter.maydell@linaro.org \
    --to=peter.maydell@linaro.org \
    --cc=aliguori@amazon.com \
    --cc=armbru@redhat.com \
    --cc=patches@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).