From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37329) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XOmin-0007JN-NL for qemu-devel@nongnu.org; Tue, 02 Sep 2014 07:58:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XOmiU-00033y-3l for qemu-devel@nongnu.org; Tue, 02 Sep 2014 07:58:01 -0400 Received: from mnementh.archaic.org.uk ([81.2.115.146]:46844) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XOmiT-00033F-QO for qemu-devel@nongnu.org; Tue, 02 Sep 2014 07:57:41 -0400 From: Peter Maydell Date: Tue, 2 Sep 2014 12:52:44 +0100 Message-Id: <1409658764-28113-4-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1409658764-28113-1-git-send-email-peter.maydell@linaro.org> References: <1409658764-28113-1-git-send-email-peter.maydell@linaro.org> Subject: [Qemu-devel] [PATCH v2 3/3] target-sparc: is_translating_asi() is TARGET_SPARC64 only List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Richard Henderson , Mark Cave-Ayland , patches@linaro.org Move the is_translating_asi() inside the TARGET_SPARC64 ifdef (and remove the unimplemented 32-bit codepath), as it is only called from TARGET_SPARC64 code. This fixes a clang 3.4 unused-function warning. Again, this allows us to remove an 'inline' tag that was there largely to suppress gcc warnings. Signed-off-by: Peter Maydell --- target-sparc/ldst_helper.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/target-sparc/ldst_helper.c b/target-sparc/ldst_helper.c index 2d028a5..9f65bc3 100644 --- a/target-sparc/ldst_helper.c +++ b/target-sparc/ldst_helper.c @@ -262,11 +262,12 @@ static target_ulong address_mask(CPUSPARCState *env1, target_ulong addr) } #endif +#ifdef TARGET_SPARC64 /* returns true if access using this ASI is to have address translated by MMU otherwise access is to raw physical address */ -static inline int is_translating_asi(int asi) +/* TODO: check sparc32 bits */ +static int is_translating_asi(int asi) { -#ifdef TARGET_SPARC64 /* Ultrasparc IIi translating asi - note this list is defined by cpu implementation */ @@ -283,13 +284,8 @@ static inline int is_translating_asi(int asi) default: return 0; } -#else - /* TODO: check sparc32 bits */ - return 0; -#endif } -#ifdef TARGET_SPARC64 static target_ulong asi_address_mask(CPUSPARCState *env, int asi, target_ulong addr) { -- 1.9.1