From: Max Reitz <mreitz@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Benoît Canet" <benoit.canet@nodalink.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Max Reitz" <mreitz@redhat.com>
Subject: [Qemu-devel] [PATCH v2 3/3] docs/qcow2: Limit refcount_order to [0, 6]
Date: Wed, 3 Sep 2014 00:25:09 +0200 [thread overview]
Message-ID: <1409696709-27623-4-git-send-email-mreitz@redhat.com> (raw)
In-Reply-To: <1409696709-27623-1-git-send-email-mreitz@redhat.com>
Specify the upper limit of refcount_order to be 6 (that is,
refcount_bits = 64). Any larger value does not make much sense when all
offsets, sizes, cluster counts etc. "only" have a width of 64 bit as
well, and very large values would be very difficult to support.
Therefore, just cap it at the largest reasonable value.
Suggested-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
---
docs/specs/qcow2.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/docs/specs/qcow2.txt b/docs/specs/qcow2.txt
index 0a878aa..121dfc8 100644
--- a/docs/specs/qcow2.txt
+++ b/docs/specs/qcow2.txt
@@ -110,6 +110,7 @@ in the description of a field.
in bits: refcount_bits = 1 << refcount_order). For version 2
images, the order is always assumed to be 4
(i.e. refcount_bits = 16).
+ This value may not exceed 6 (i.e. refcount_bits = 64).
100 - 103: header_length
Length of the header structure in bytes. For version 2
--
2.1.0
next prev parent reply other threads:[~2014-09-02 22:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 22:25 [Qemu-devel] [PATCH v2 0/3] qcow2: Drop REFCOUNT_SHIFT Max Reitz
2014-09-02 22:25 ` [Qemu-devel] [PATCH v2 1/3] " Max Reitz
2014-09-02 22:25 ` [Qemu-devel] [PATCH v2 2/3] docs/qcow2: Correct refcount_block_entries Max Reitz
2014-09-02 22:28 ` Eric Blake
2014-09-03 13:51 ` Stefan Hajnoczi
2014-09-02 22:25 ` Max Reitz [this message]
2014-09-02 22:30 ` [Qemu-devel] [PATCH v2 3/3] docs/qcow2: Limit refcount_order to [0, 6] Eric Blake
2014-09-03 13:51 ` Stefan Hajnoczi
2014-10-22 12:14 ` [Qemu-devel] [PATCH v2 0/3] qcow2: Drop REFCOUNT_SHIFT Kevin Wolf
2014-10-22 13:18 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409696709-27623-4-git-send-email-mreitz@redhat.com \
--to=mreitz@redhat.com \
--cc=benoit.canet@nodalink.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).