From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41860)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1XP406-0006WX-Px
	for qemu-devel@nongnu.org; Wed, 03 Sep 2014 02:25:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1XP400-00024J-LH
	for qemu-devel@nongnu.org; Wed, 03 Sep 2014 02:25:02 -0400
Received: from mx1.redhat.com ([209.132.183.28]:17845)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1XP400-00024F-CA
	for qemu-devel@nongnu.org; Wed, 03 Sep 2014 02:24:56 -0400
Message-ID: <1409725473.9430.3.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Wed, 03 Sep 2014 08:24:33 +0200
In-Reply-To: <33183CC9F5247A488A2544077AF1902086DC0CCE@SZXEMA503-MBS.china.huawei.com>
References: <1409392827-9372-1-git-send-email-arei.gonglei@huawei.com>
	<1409392827-9372-3-git-send-email-arei.gonglei@huawei.com>
	<1409553800.708.3.camel@nilsson.home.kraxel.org>
	<33183CC9F5247A488A2544077AF1902086DBEA84@SZXEMA503-MBS.china.huawei.com>
	<20140902180012.GQ32084@thinpad.lan.raisama.net>
	<33183CC9F5247A488A2544077AF1902086DC0CCE@SZXEMA503-MBS.china.huawei.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v6 02/27] bootindex: add
	del_boot_device_path function
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Gonglei (Arei)" <arei.gonglei@huawei.com>
Cc: "chenliang (T)" <chenliang88@huawei.com>, "Huangweidong (C)" <weidong.huang@huawei.com>, "mst@redhat.com" <mst@redhat.com>, "aik@ozlabs.ru" <aik@ozlabs.ru>, "hutao@cn.fujitsu.com" <hutao@cn.fujitsu.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "armbru@redhat.com" <armbru@redhat.com>, "akong@redhat.com" <akong@redhat.com>, "agraf@suse.de" <agraf@suse.de>, "aliguori@amazon.com" <aliguori@amazon.com>, Eduardo Habkost <ehabkost@redhat.com>, Luonengjun <luonengjun@huawei.com>, "Huangpeng (Peter)" <peter.huangpeng@huawei.com>, "hani@linux.com" <hani@linux.com>, "stefanha@redhat.com" <stefanha@redhat.com>, "pbonzini@redhat.com" <pbonzini@redhat.com>, "lcapitulino@redhat.com" <lcapitulino@redhat.com>, "kwolf@redhat.com" <kwolf@redhat.com>, "peter.crosthwaite@xilinx.com" <peter.crosthwaite@xilinx.com>, "imammedo@redhat.com" <imammedo@redhat.com>, "afaerber@suse.de" <afaerber@suse.de>


  Hi,

> 4. When we hotplug the virtio-net-pci device, only pass virtio-net-pci's pointer to 
> del_boot_device_path(). But virtio-net-pci != virtio-net-device, so I add a function
> named is_same_fw_dev_path() to handle this situation. 

When hot-unplugging virtio-net-pci I'd expect we free both
virtio-net-pci and virtio-net-device (and therefore call
del_boot_device_path twice, once for each device).  Can you check that?

thanks,
  Gerd