From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55063) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XP8gq-0006KF-Qv for qemu-devel@nongnu.org; Wed, 03 Sep 2014 07:25:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XP8gj-000759-K5 for qemu-devel@nongnu.org; Wed, 03 Sep 2014 07:25:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49056) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XP8gj-00074r-Do for qemu-devel@nongnu.org; Wed, 03 Sep 2014 07:25:21 -0400 From: Fam Zheng Date: Wed, 3 Sep 2014 19:23:42 +0800 Message-Id: <1409743435-21155-8-git-send-email-famz@redhat.com> In-Reply-To: <1409743435-21155-1-git-send-email-famz@redhat.com> References: <1409743435-21155-1-git-send-email-famz@redhat.com> Subject: [Qemu-devel] [PATCH v4 07/20] dma: Check iov pointer before unmap memory List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Chrysostomos Nanakos , Stefan Hajnoczi , Liu Yuan , Peter Lieven , Ronnie Sahlberg , Josh Durgin , Paolo Bonzini , MORITA Kazutaka , Benoit Canet Not all the iov elements are always valid. Signed-off-by: Fam Zheng --- dma-helpers.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/dma-helpers.c b/dma-helpers.c index 499b52b..3655d88 100644 --- a/dma-helpers.c +++ b/dma-helpers.c @@ -105,6 +105,9 @@ static void dma_bdrv_unmap(DMAAIOCB *dbs) int i; for (i = 0; i < dbs->iov.niov; ++i) { + if (!(dbs->iov.iov[i].iov_base && dbs->iov.iov[i].iov_len)) { + break; + } dma_memory_unmap(dbs->sg->as, dbs->iov.iov[i].iov_base, dbs->iov.iov[i].iov_len, dbs->dir, dbs->iov.iov[i].iov_len); -- 2.1.0.27.g96db324