qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Andrey Korolyov <andrey@xdel.ru>,
	Jason Wang <jasowang@redhat.com>,
	qemu-stable@nongnu.org,
	Nikolay Nikolaev <n.nikolaev@virtualopensystems.com>,
	Anthony Liguori <aliguori@amazon.com>
Subject: [Qemu-devel] [PULL v2 14/16] vhost_net: init acked_features to backend_features
Date: Wed, 3 Sep 2014 16:45:40 +0300	[thread overview]
Message-ID: <1409751723-17480-15-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1409751723-17480-1-git-send-email-mst@redhat.com>

From: Jason Wang <jasowang@redhat.com>

commit 2e6d46d77ed328d34a94688da8371bcbe243479b (vhost: add
vhost_get_features and vhost_ack_features) removes the step that
initializes the acked_features to backend_features.

As this field is now uninitialized, vhost initialization will sometimes
fail.

To fix, initialize acked_features on each ack.

Tested-by: Andrey Korolyov <andrey@xdel.ru>
Cc: Nikolay Nikolaev <n.nikolaev@virtualopensystems.com>
Cc: qemu-stable@nongnu.org
Signed-off-by: Jason Wang <jasowang@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 hw/net/vhost_net.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c
index 3819044..b21e7a4 100644
--- a/hw/net/vhost_net.c
+++ b/hw/net/vhost_net.c
@@ -115,6 +115,7 @@ unsigned vhost_net_get_features(struct vhost_net *net, unsigned features)
 
 void vhost_net_ack_features(struct vhost_net *net, unsigned features)
 {
+    net->dev.acked_features = net->dev.backend_features;
     vhost_ack_features(&net->dev, vhost_net_get_feature_bits(net), features);
 }
 
-- 
MST

  parent reply	other threads:[~2014-09-03 13:42 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-03 13:44 [Qemu-devel] [PULL v2 00/16] pci, pc fixes, features Michael S. Tsirkin
2014-09-03 13:44 ` [Qemu-devel] [PULL v2 01/16] iommu: add is_write as a parameter to the translate function of MemoryRegionIOMMUOps Michael S. Tsirkin
2014-09-03 13:44 ` [Qemu-devel] [PULL v2 02/16] intel-iommu: introduce Intel IOMMU (VT-d) emulation Michael S. Tsirkin
2014-09-03 13:44 ` [Qemu-devel] [PULL v2 03/16] intel-iommu: add DMAR table to ACPI tables Michael S. Tsirkin
2014-09-03 13:45 ` [Qemu-devel] [PULL v2 04/16] intel-iommu: add Intel IOMMU emulation to q35 and add a machine option "iommu" as a switch Michael S. Tsirkin
2014-09-03 13:45 ` [Qemu-devel] [PULL v2 05/16] intel-iommu: fix coding style issues around in q35.c and machine.c Michael S. Tsirkin
2014-09-03 13:45 ` [Qemu-devel] [PULL v2 06/16] intel-iommu: add supports for queued invalidation interface Michael S. Tsirkin
2014-09-03 13:45 ` [Qemu-devel] [PULL v2 07/16] intel-iommu: add context-cache to cache context-entry Michael S. Tsirkin
2014-09-03 13:45 ` [Qemu-devel] [PULL v2 08/16] intel-iommu: add IOTLB using hash table Michael S. Tsirkin
2014-09-03 13:45 ` [Qemu-devel] [PULL v2 09/16] vhost_net: cleanup start/stop condition Michael S. Tsirkin
2014-09-03 13:45 ` [Qemu-devel] [PULL v2 10/16] ioh3420: remove unused ioh3420_init() declaration Michael S. Tsirkin
2014-09-03 13:45 ` [Qemu-devel] [PULL v2 11/16] virtio-net: don't run bh on vm stopped Michael S. Tsirkin
2014-09-03 13:45 ` [Qemu-devel] [PULL v2 12/16] pci: avoid losing config updates to MSI/MSIX cap regs Michael S. Tsirkin
2014-09-03 13:45 ` [Qemu-devel] [PULL v2 13/16] vhost_net: start/stop guest notifiers properly Michael S. Tsirkin
2014-09-03 13:45 ` Michael S. Tsirkin [this message]
2014-09-03 13:45 ` [Qemu-devel] [PULL v2 15/16] vhost-scsi: init backend features earlier Michael S. Tsirkin
2014-09-03 13:45 ` [Qemu-devel] [PULL v2 16/16] acpi-build: Set FORCE_APIC_CLUSTER_MODEL bit for FADT flags Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1409751723-17480-15-git-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=aliguori@amazon.com \
    --cc=andrey@xdel.ru \
    --cc=jasowang@redhat.com \
    --cc=n.nikolaev@virtualopensystems.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).