From: Gerd Hoffmann <kraxel@redhat.com>
To: arei.gonglei@huawei.com
Cc: chenliang88@huawei.com, weidong.huang@huawei.com, mst@redhat.com,
aik@ozlabs.ru, hutao@cn.fujitsu.com, qemu-devel@nongnu.org,
armbru@redhat.com, akong@redhat.com, agraf@suse.de,
aliguori@amazon.com, ehabkost@redhat.com, luonengjun@huawei.com,
peter.huangpeng@huawei.com, hani@linux.com, stefanha@redhat.com,
pbonzini@redhat.com, lcapitulino@redhat.com, kwolf@redhat.com,
peter.crosthwaite@xilinx.com, imammedo@redhat.com,
afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH v7 18/28] host-libusb: remove bootindex property from qdev to qom
Date: Fri, 05 Sep 2014 11:06:06 +0200 [thread overview]
Message-ID: <1409907966.20018.7.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <1409906256-11368-19-git-send-email-arei.gonglei@huawei.com>
> +static void usb_host_instance_init(Object *obj)
> +{
> + USBDevice *udev = USB_DEVICE(obj);
> + USBHostDevice *s = USB_HOST_DEVICE(udev);
> +
> + device_add_bootindex_property(obj, &s->bootindex,
> + "bootindex", NULL,
> + &udev->qdev, NULL);
> + object_property_set_int(obj, -1, "bootindex", NULL);
I think the object_property_set_int() call can be moved to
device_add_bootindex_property, so there is no need to duplicate the call
to init bootindex with -1 in all devices.
cheers,
Gerd
next prev parent reply other threads:[~2014-09-05 9:06 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-05 8:37 [Qemu-devel] [PATCH v7 00/28] modify boot order of guest, and take effect after rebooting arei.gonglei
2014-09-05 8:37 ` [Qemu-devel] [PATCH v7 01/28] bootdevice: move bootdevice related code to new file bootdevice.c arei.gonglei
2014-09-05 8:37 ` [Qemu-devel] [PATCH v7 02/28] bootindex: add check bootindex function arei.gonglei
2014-09-05 8:37 ` [Qemu-devel] [PATCH v7 03/28] bootindex: add del_boot_device_path function arei.gonglei
2014-09-05 8:37 ` [Qemu-devel] [PATCH v7 04/28] fw_cfg: add fw_cfg_machine_reset function arei.gonglei
2014-09-05 8:37 ` [Qemu-devel] [PATCH v7 05/28] bootindex: rework add_boot_device_path function arei.gonglei
2014-09-05 18:15 ` Eduardo Habkost
2014-09-08 11:54 ` Gonglei
2014-09-05 8:37 ` [Qemu-devel] [PATCH v7 06/28] bootindex: support to set a existent device's bootindex to -1 arei.gonglei
2014-09-05 8:37 ` [Qemu-devel] [PATCH v7 07/28] bootindex: add a setter/getter functions wrapper for bootindex property arei.gonglei
2014-09-05 8:37 ` [Qemu-devel] [PATCH v7 08/28] virtio-net: add bootindex to qom property arei.gonglei
2014-09-05 18:28 ` Eduardo Habkost
2014-09-08 12:07 ` Gonglei
2014-09-09 8:03 ` Gonglei (Arei)
2014-09-05 8:37 ` [Qemu-devel] [PATCH v7 09/28] e1000: " arei.gonglei
2014-09-05 8:37 ` [Qemu-devel] [PATCH v7 10/28] eepro100: " arei.gonglei
2014-09-05 8:37 ` [Qemu-devel] [PATCH v7 11/28] ne2000: " arei.gonglei
2014-09-05 8:37 ` [Qemu-devel] [PATCH v7 12/28] pcnet: " arei.gonglei
2014-09-05 8:37 ` [Qemu-devel] [PATCH v7 13/28] rtl8139: " arei.gonglei
2014-09-05 8:37 ` [Qemu-devel] [PATCH v7 14/28] spapr_lian: " arei.gonglei
2014-09-05 8:37 ` [Qemu-devel] [PATCH v7 15/28] vmxnet3: " arei.gonglei
2014-09-05 8:37 ` [Qemu-devel] [PATCH v7 16/28] usb-net: " arei.gonglei
2014-09-05 8:37 ` [Qemu-devel] [PATCH v7 17/28] net: remove bootindex property from qdev to qom arei.gonglei
2014-09-05 8:37 ` [Qemu-devel] [PATCH v7 18/28] host-libusb: " arei.gonglei
2014-09-05 9:06 ` Gerd Hoffmann [this message]
2014-09-05 9:12 ` Gonglei (Arei)
2014-09-05 8:37 ` [Qemu-devel] [PATCH v7 19/28] pci-assign: " arei.gonglei
2014-09-05 8:37 ` [Qemu-devel] [PATCH v7 20/28] vfio: " arei.gonglei
2014-09-05 8:37 ` [Qemu-devel] [PATCH v7 21/28] redirect: " arei.gonglei
2014-09-05 8:37 ` [Qemu-devel] [PATCH v7 22/28] isa-fdc: remove bootindexA/B " arei.gonglei
2014-09-05 8:37 ` [Qemu-devel] [PATCH v7 23/28] scsi: add bootindex to qom property arei.gonglei
2014-09-05 8:37 ` [Qemu-devel] [PATCH v7 24/28] ide: " arei.gonglei
2014-09-05 18:39 ` Eduardo Habkost
2014-09-08 12:07 ` Gonglei
2014-09-09 7:51 ` Gonglei (Arei)
2014-09-09 16:18 ` Eduardo Habkost
2014-09-10 1:21 ` Gonglei (Arei)
2014-09-05 8:37 ` [Qemu-devel] [PATCH v7 25/28] virtio-blk: " arei.gonglei
2014-09-05 8:37 ` [Qemu-devel] [PATCH v7 26/28] block: remove bootindex property from qdev to qom arei.gonglei
2014-09-05 8:37 ` [Qemu-devel] [PATCH v7 27/28] bootindex: move calling add_boot_device_patch to bootindex setter function arei.gonglei
2014-09-05 8:37 ` [Qemu-devel] [PATCH v7 28/28] bootindex: delete bootindex when device is removed arei.gonglei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409907966.20018.7.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=akong@redhat.com \
--cc=aliguori@amazon.com \
--cc=arei.gonglei@huawei.com \
--cc=armbru@redhat.com \
--cc=chenliang88@huawei.com \
--cc=ehabkost@redhat.com \
--cc=hani@linux.com \
--cc=hutao@cn.fujitsu.com \
--cc=imammedo@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=luonengjun@huawei.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=peter.huangpeng@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=weidong.huang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).