* [Qemu-devel] [PATCH] spice: call qemu_spice_set_passwd() during init
@ 2014-09-05 12:08 Marc-André Lureau
2014-09-05 12:11 ` Gerd Hoffmann
0 siblings, 1 reply; 2+ messages in thread
From: Marc-André Lureau @ 2014-09-05 12:08 UTC (permalink / raw)
To: qemu-devel; +Cc: Marc-André Lureau, kraxel
Don't call SPICE API directly to set password given in command line, but
use the internal API, saving password for later calls.
This solves losing password when changing expiration in qemu monitor.
https://bugzilla.redhat.com/show_bug.cgi?id=1138639
---
ui/spice-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui/spice-core.c b/ui/spice-core.c
index 7bb91e6..f2e6521 100644
--- a/ui/spice-core.c
+++ b/ui/spice-core.c
@@ -733,7 +733,7 @@ void qemu_spice_init(void)
tls_ciphers);
}
if (password) {
- spice_server_set_ticket(spice_server, password, 0, 0, 0);
+ qemu_spice_set_passwd(password, false, false);
}
if (qemu_opt_get_bool(opts, "sasl", 0)) {
if (spice_server_set_sasl_appname(spice_server, "qemu") == -1 ||
--
1.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] spice: call qemu_spice_set_passwd() during init
2014-09-05 12:08 [Qemu-devel] [PATCH] spice: call qemu_spice_set_passwd() during init Marc-André Lureau
@ 2014-09-05 12:11 ` Gerd Hoffmann
0 siblings, 0 replies; 2+ messages in thread
From: Gerd Hoffmann @ 2014-09-05 12:11 UTC (permalink / raw)
To: Marc-André Lureau; +Cc: qemu-devel
On Fr, 2014-09-05 at 14:08 +0200, Marc-André Lureau wrote:
> Don't call SPICE API directly to set password given in command line, but
> use the internal API, saving password for later calls.
>
> This solves losing password when changing expiration in qemu monitor.
Makes sense. Added to spice patch queue.
thanks,
Gerd
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-09-05 12:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-05 12:08 [Qemu-devel] [PATCH] spice: call qemu_spice_set_passwd() during init Marc-André Lureau
2014-09-05 12:11 ` Gerd Hoffmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).