qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PULL 12/24] qemu-img: fix rebase src_cache option documentation
Date: Mon,  8 Sep 2014 11:51:37 +0100	[thread overview]
Message-ID: <1410173509-26667-13-git-send-email-stefanha@redhat.com> (raw)
In-Reply-To: <1410173509-26667-1-git-send-email-stefanha@redhat.com>

The src_cache option (-T) specifies the cache mode for backing files.
It applies both the image's old backing file as well as the new backing
file:

  ret = bdrv_open(&bs_old_backing, backing_name, NULL, NULL, src_flags,
                  old_backing_drv, &local_err);
  if (ret) {
      ...
  }
  if (out_baseimg[0]) {
      bs_new_backing = bdrv_new("new_backing", &error_abort);
      ret = bdrv_open(&bs_new_backing, out_baseimg, NULL, NULL, src_flags,
                      new_backing_drv, &local_err);
      if (ret) {
          ...
      }
  }

The documentation only mentions the new backing file but it really
applies to both.

Suggested-by: Jeff Nelson <jenelson@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
---
 qemu-img.texi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qemu-img.texi b/qemu-img.texi
index 4380d56..cc4668e 100644
--- a/qemu-img.texi
+++ b/qemu-img.texi
@@ -341,7 +341,7 @@ string), then the image is rebased onto no backing file (i.e. it will exist
 independently of any backing file).
 
 @var{cache} specifies the cache mode to be used for @var{filename}, whereas
-@var{src_cache} specifies the cache mode for reading the new backing file.
+@var{src_cache} specifies the cache mode for reading backing files.
 
 There are two different modes in which @code{rebase} can operate:
 @table @option
-- 
1.9.3

  parent reply	other threads:[~2014-09-08 10:52 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-08 10:51 [Qemu-devel] [PULL v2 00/24] Block patches Stefan Hajnoczi
2014-09-08 10:51 ` [Qemu-devel] [PULL 01/24] block: kill tail whitespace in block.c Stefan Hajnoczi
2014-09-08 10:51 ` [Qemu-devel] [PULL 02/24] pflash_cfi01: fixup stale DPRINTF() calls Stefan Hajnoczi
2014-09-08 10:51 ` [Qemu-devel] [PULL 03/24] pflash_cfi01: write flash contents to bdrv on incoming migration Stefan Hajnoczi
2014-09-08 10:51 ` [Qemu-devel] [PULL 04/24] tests: Functions bus_foreach and device_find from libqos virtio API Stefan Hajnoczi
2014-09-08 10:51 ` [Qemu-devel] [PULL 05/24] tests: Add virtio device initialization Stefan Hajnoczi
2014-09-08 10:51 ` [Qemu-devel] [PULL 06/24] libqos: Added basic virtqueue support to virtio implementation Stefan Hajnoczi
2014-09-08 10:51 ` [Qemu-devel] [PULL 07/24] libqos: Added indirect descriptor " Stefan Hajnoczi
2014-09-08 10:51 ` [Qemu-devel] [PULL 08/24] libqos: Added test case for configuration changes in virtio-blk test Stefan Hajnoczi
2014-09-08 10:51 ` [Qemu-devel] [PULL 09/24] libqos: Added MSI-X support Stefan Hajnoczi
2014-09-08 10:51 ` [Qemu-devel] [PULL 10/24] libqos: Added EVENT_IDX support Stefan Hajnoczi
2014-09-08 10:51 ` [Qemu-devel] [PULL 11/24] qemu-img: clarify src_cache option documentation Stefan Hajnoczi
2014-09-08 10:51 ` Stefan Hajnoczi [this message]
2014-09-08 10:51 ` [Qemu-devel] [PULL 13/24] block/archipelago: Use QEMU atomic builtins Stefan Hajnoczi
2014-09-08 10:51 ` [Qemu-devel] [PULL 14/24] rename parse_enum_option to qapi_enum_parse and make it public Stefan Hajnoczi
2014-09-08 10:51 ` [Qemu-devel] [PULL 15/24] qemu-nbd: add option to set detect-zeroes mode Stefan Hajnoczi
2014-09-08 10:51 ` [Qemu-devel] [PULL 16/24] qemu-nbd: fix indentation and coding style Stefan Hajnoczi
2014-09-08 10:51 ` [Qemu-devel] [PULL 17/24] MAINTAINERS: update sheepdog maintainer Stefan Hajnoczi
2014-09-08 10:51 ` [Qemu-devel] [PULL 18/24] libqos: add a simple first-fit memory allocator Stefan Hajnoczi
2014-09-08 10:51 ` [Qemu-devel] [PULL 19/24] qtest/ide: Uninitialize PC allocator Stefan Hajnoczi
2014-09-08 10:51 ` [Qemu-devel] [PULL 20/24] ide: Add wwn support to IDE-ATAPI drive Stefan Hajnoczi
2014-09-08 10:51 ` [Qemu-devel] [PULL 21/24] vmdk: fix vmdk_parse_extents() extent_file leaks Stefan Hajnoczi
2014-09-08 10:51 ` [Qemu-devel] [PULL 22/24] vmdk: fix buf leak in vmdk_parse_extents() Stefan Hajnoczi
2014-09-08 10:51 ` [Qemu-devel] [PULL 23/24] IDE: Fill the IDENTIFY request consistently Stefan Hajnoczi
2014-09-08 10:51 ` [Qemu-devel] [PULL 24/24] ide: Add resize callback to ide/core Stefan Hajnoczi
2014-09-08 14:06 ` [Qemu-devel] [PULL v2 00/24] Block patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1410173509-26667-13-git-send-email-stefanha@redhat.com \
    --to=stefanha@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).