From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38905) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XQwYz-0004I1-Sd for qemu-devel@nongnu.org; Mon, 08 Sep 2014 06:52:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XQwYt-0007ye-Oy for qemu-devel@nongnu.org; Mon, 08 Sep 2014 06:52:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9654) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XQwYt-0007yE-HZ for qemu-devel@nongnu.org; Mon, 08 Sep 2014 06:52:43 -0400 From: Stefan Hajnoczi Date: Mon, 8 Sep 2014 11:51:46 +0100 Message-Id: <1410173509-26667-22-git-send-email-stefanha@redhat.com> In-Reply-To: <1410173509-26667-1-git-send-email-stefanha@redhat.com> References: <1410173509-26667-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PULL 21/24] vmdk: fix vmdk_parse_extents() extent_file leaks List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell , Stefan Hajnoczi Signed-off-by: Stefan Hajnoczi Reviewed-by: Max Reitz Reviewed-by: Fam Zheng --- block/vmdk.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/block/vmdk.c b/block/vmdk.c index 07cb62c..9bf28f3 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -834,6 +834,7 @@ static int vmdk_parse_extents(const char *desc, BlockDriverState *bs, ret = vmdk_add_extent(bs, extent_file, true, sectors, 0, 0, 0, 0, 0, &extent, errp); if (ret < 0) { + bdrv_unref(extent_file); return ret; } extent->flat_start_offset = flat_offset << 9; @@ -853,6 +854,7 @@ static int vmdk_parse_extents(const char *desc, BlockDriverState *bs, extent = &s->extents[s->num_extents - 1]; } else { error_setg(errp, "Unsupported extent type '%s'", type); + bdrv_unref(extent_file); return -ENOTSUP; } extent->type = g_strdup(type); -- 1.9.3