From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53263) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XR29n-0003ew-FV for qemu-devel@nongnu.org; Mon, 08 Sep 2014 12:51:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XR29h-00039M-BY for qemu-devel@nongnu.org; Mon, 08 Sep 2014 12:51:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:26885) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XR29h-00039B-3w for qemu-devel@nongnu.org; Mon, 08 Sep 2014 12:51:05 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s88Gp41e001836 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 8 Sep 2014 12:51:04 -0400 From: Markus Armbruster Date: Mon, 8 Sep 2014 18:51:00 +0200 Message-Id: <1410195061-8267-4-git-send-email-armbru@redhat.com> In-Reply-To: <1410195061-8267-1-git-send-email-armbru@redhat.com> References: <1410195061-8267-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH 3/4] xen: Drop redundant bdrv_close() from pci_piix3_xen_ide_unplug() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@redhat.com drive_del() closes just fine. Signed-off-by: Markus Armbruster --- hw/ide/piix.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/ide/piix.c b/hw/ide/piix.c index 59319eb..49e78a7 100644 --- a/hw/ide/piix.c +++ b/hw/ide/piix.c @@ -182,7 +182,6 @@ int pci_piix3_xen_ide_unplug(DeviceState *dev) if (ds) { bdrv_detach_dev(di->bdrv, ds); } - bdrv_close(di->bdrv); pci_ide->bus[di->bus].ifs[di->unit].bs = NULL; drive_del(di); } -- 1.9.3