From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32849) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XRd2c-0002EJ-Bj for qemu-devel@nongnu.org; Wed, 10 Sep 2014 04:14:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XRd2U-0003oU-Ls for qemu-devel@nongnu.org; Wed, 10 Sep 2014 04:14:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33094) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XRd2U-0003nu-Dn for qemu-devel@nongnu.org; Wed, 10 Sep 2014 04:14:06 -0400 From: Markus Armbruster Date: Wed, 10 Sep 2014 10:13:46 +0200 Message-Id: <1410336832-22160-18-git-send-email-armbru@redhat.com> In-Reply-To: <1410336832-22160-1-git-send-email-armbru@redhat.com> References: <1410336832-22160-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH 17/23] blockdev: Drop superfluous DriveInfo member id List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, benoit.canet@irqsave.net, famz@redhat.com, stefanha@redhat.com Signed-off-by: Markus Armbruster --- block/block-backend.c | 1 - blockdev.c | 3 +-- include/sysemu/blockdev.h | 1 - 3 files changed, 1 insertion(+), 4 deletions(-) diff --git a/block/block-backend.c b/block/block-backend.c index cc21f3c..1bac033 100644 --- a/block/block-backend.c +++ b/block/block-backend.c @@ -123,7 +123,6 @@ static void drive_info_del(DriveInfo *dinfo) { if (dinfo) { qemu_opts_del(dinfo->opts); - g_free(dinfo->id); g_free(dinfo->serial); g_free(dinfo); } diff --git a/blockdev.c b/blockdev.c index 6f1e479..4488dfd 100644 --- a/blockdev.c +++ b/blockdev.c @@ -458,7 +458,6 @@ static BlockBackend *blockdev_init(const char *file, QDict *bs_opts, } dinfo = g_malloc0(sizeof(*dinfo)); - dinfo->id = g_strdup(qemu_opts_id(opts)); blk_set_legacy_dinfo(blk, dinfo); if (!file || !*file) { @@ -492,7 +491,7 @@ static BlockBackend *blockdev_init(const char *file, QDict *bs_opts, if (ret < 0) { error_setg(errp, "could not open disk image %s: %s", - file ?: dinfo->id, error_get_pretty(error)); + file ?: blk_name(blk), error_get_pretty(error)); error_free(error); goto err; } diff --git a/include/sysemu/blockdev.h b/include/sysemu/blockdev.h index f66b89a..27a40d5 100644 --- a/include/sysemu/blockdev.h +++ b/include/sysemu/blockdev.h @@ -30,7 +30,6 @@ typedef enum { } BlockInterfaceType; struct DriveInfo { - char *id; const char *devaddr; BlockInterfaceType type; int bus; -- 1.9.3