From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48561) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XRiB4-0001Eb-1I for qemu-devel@nongnu.org; Wed, 10 Sep 2014 09:43:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XRiAz-0000SN-8x for qemu-devel@nongnu.org; Wed, 10 Sep 2014 09:43:17 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:36003) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XRiAy-0000Qw-Vm for qemu-devel@nongnu.org; Wed, 10 Sep 2014 09:43:13 -0400 From: Owen smith Date: Wed, 10 Sep 2014 14:42:24 +0100 Message-ID: <1410356546-22264-2-git-send-email-owen.smith@citrix.com> In-Reply-To: <1410356546-22264-1-git-send-email-owen.smith@citrix.com> References: <1410356546-22264-1-git-send-email-owen.smith@citrix.com> MIME-Version: 1.0 Content-Type: text/plain Subject: [Qemu-devel] [PATCH 1/3] xenfb: Unregister keyboard event handler correctly List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: stefano.stabellini@eu.citrix.com, Owen smith , xen-devel@lists.xen.org Keyboard event handler was replaced with a new handler on disconnect. Use the unregister function to remove keyboard handler. Signed-off-by: Owen smith --- hw/display/xenfb.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/hw/display/xenfb.c b/hw/display/xenfb.c index 07ddc9d..2c39753 100644 --- a/hw/display/xenfb.c +++ b/hw/display/xenfb.c @@ -62,6 +62,7 @@ struct XenInput { int abs_pointer_wanted; /* Whether guest supports absolute pointer */ int button_state; /* Last seen pointer button state */ int extended; + QEMUPutKbdEntry *qkbd; QEMUPutMouseEntry *qmouse; }; @@ -364,7 +365,6 @@ static int input_initialise(struct XenDevice *xendev) if (rc != 0) return rc; - qemu_add_kbd_event_handler(xenfb_key_event, in); return 0; } @@ -383,17 +383,26 @@ static void input_connected(struct XenDevice *xendev) in->qmouse = qemu_add_mouse_event_handler(xenfb_mouse_event, in, in->abs_pointer_wanted, "Xen PVFB Mouse"); + qemu_activate_mouse_event_handler(in->qmouse); + + if (in->qkbd) { + qemu_remove_kbd_event_handler(in->qkbd); + } + in->qkbd = qemu_add_kbd_event_handler(xenfb_key_event, in); } static void input_disconnect(struct XenDevice *xendev) { struct XenInput *in = container_of(xendev, struct XenInput, c.xendev); + if (in->qkbd) { + qemu_remove_kbd_event_handler(in->qkbd); + in->qkbd = NULL; + } if (in->qmouse) { qemu_remove_mouse_event_handler(in->qmouse); in->qmouse = NULL; } - qemu_add_kbd_event_handler(NULL, NULL); common_unbind(&in->c); } -- 2.1.0