From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53937) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XRwRy-0001E2-92 for qemu-devel@nongnu.org; Thu, 11 Sep 2014 00:57:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XRwRp-0001EX-9N for qemu-devel@nongnu.org; Thu, 11 Sep 2014 00:57:42 -0400 Received: from mail-qc0-x231.google.com ([2607:f8b0:400d:c01::231]:54566) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XRwRp-0001EO-3q for qemu-devel@nongnu.org; Thu, 11 Sep 2014 00:57:33 -0400 Received: by mail-qc0-f177.google.com with SMTP id i8so20615127qcq.36 for ; Wed, 10 Sep 2014 21:57:32 -0700 (PDT) Message-ID: <1410411448.19969.1.camel@gmail.com> From: Jan Vesely Date: Thu, 11 Sep 2014 00:57:28 -0400 In-Reply-To: <1397629640.23535.7.camel@nilsson.home.kraxel.org> References: <1392639007.26953.28.camel@nilsson.home.kraxel.org> <1393141071-14204-1-git-send-email-jano.vesely@gmail.com> <1396857728.5001.45.camel@nilsson.home.kraxel.org> <1397629640.23535.7.camel@nilsson.home.kraxel.org> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-1Y0oYkPj7WXch/f3XuB9" Mime-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH v2 1/2] usb-hid: Add high speed mouse configuration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: QEMU --=-1Y0oYkPj7WXch/f3XuB9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Gerd, sorry for taking so long to get back to this. My schedule has been super busy past couple of months. I have rebased the patches and moved the usb version desc selection to hid_initfn as you suggested. I also made the changes follow the tablet example as closely as possible I tested the patches on ubuntu 64 and fedora 64 liveCDs and both mouse and keyboard still work ok. thanks, jan On Wed, 2014-04-16 at 08:27 +0200, Gerd Hoffmann wrote: > On Di, 2014-04-15 at 19:33 -0400, J=C3=A1n Vesel=C3=BD wrote: > > Hi, > >=20 > > I found some more time to work on this. However, I'm not sure I > > understand the purpose of compat property: > > I noticed that the only place it's set is in PC_COMPAT_1_3 (is this > > what you meant by older devices?), >=20 > Older machine types, yes. This switches the tablet to usb1 by default > if you start qemu with -M pc-1.3 (or older), because it was usb1 only in > qemu 1.3 & older. >=20 > > I guess same setting for FS mouse and kbd should be added there as well= . >=20 > They need to go to the (probably not added yet) PC_COMPAT_2_0. >=20 > > The switch statement in usb_tablet_initfn selects between two > > descriptor structures, however, these structures are almost identical > > with the sole exception of .high field being set in the HS version > > (desc_tablet2). > >=20 > > So changing the switch statement to: > > if (us->usb_version < 2) > > dev->usb_desc->high =3D NULL; > >=20 > > should be OK for all usb hid devices, right? >=20 > No. That struct is shared between all device instances, so if you muck > with it all devices are affected, i.e. this ... >=20 > qemu -device usb-tablet,usb_ver=3D1 -device usb_tablet,usb_ver=3D2 >=20 > will not work correctly. >=20 > cheers, > Gerd >=20 >=20 --=-1Y0oYkPj7WXch/f3XuB9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCgAGBQJUESu5AAoJEOCQZixVs7KBzBoP/jkFw1Cez3FDfujtoc2Tf/zx KbX2hPQQYpgIeExf1m5q1K4ooRfDzU5AGQRaTCLuxq2c+nVgejeyXEUKqDs8x/9x /3dOrEHy0+/99O0YJ3GjziZXf05S/nP1H0JRYDcdQam9Ys5PiixRGu1hvMCgFTBe Nhj8nAR4VRt6qWSgK2dLCXM65brvP50GAGIMUDkcVg0IadIk9C1fh14wEqKxlj8F dOLz0YIctZcSsAXiOZsGyYiJdkfax0u46JNQRDnJQOo4bD64KadUCJcq/H58TwX0 tTQnGsvrSxhantrQtK+dpxcDReOBzwesIgdJAduUhKOnbpFfTrIc06hQ+qk4CUYS 2FPJyt9xW7mQGj/+h1Zz46ShP8b8bKPu/sJtAf8zccKcGcAP9iD01KVIdfK78muW mw2Tw5Mkc82tbZTHFksi48bg3vViUPyuVT2NmH6H3+zH6CNiNhauBP7/wKwwD759 YoNzKH3MgJUlMQWNbnyKM4dB1j2tchW9tgDoD5BFaH62E8L5aqKJA/737niaqxE1 uiuhm6v8ePzNmdnyv+UEeUFMOYs2z1OEljspawGnQFmtLyumcyjhIHHK1YjGaOhm JFljpmi27mvH1x8161rP9HAkDCEuQURsZr0PfCHw/H+TwL5ei+QL4EW/RM/58f+8 0+5s5R3v2MrAyAjePG3r =3ka8 -----END PGP SIGNATURE----- --=-1Y0oYkPj7WXch/f3XuB9--