From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49754) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XRyiE-0005ta-GN for qemu-devel@nongnu.org; Thu, 11 Sep 2014 03:22:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XRyi7-0004a6-QZ for qemu-devel@nongnu.org; Thu, 11 Sep 2014 03:22:38 -0400 Message-ID: <1410420145.6138.7.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Thu, 11 Sep 2014 09:22:25 +0200 In-Reply-To: <1410419467-9932-1-git-send-email-aik@ozlabs.ru> References: <1410419467-9932-1-git-send-email-aik@ozlabs.ru> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] ohci: Stop OHCI bus when PCI bus master is disabled List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Alexander Graf On Do, 2014-09-11 at 17:11 +1000, Alexey Kardashevskiy wrote: > When the guest performs kexec() (for example, as a part of kdump), > new kernel does PCI probing. As a part of it, PCI_COMMAND_MASTER > gets disabled which disables bus master memory region. > Since ohci_frame_boundary() timer is not stopped at this point > as OHCI device was not reset, the device tries accessing DMA memory, > fails and ends up in ohci_die() producing errors: > > usb-ohci: HCCA read error at 30000000 > ohci_die: DMA error Which is the correct behavior. IMHO the kernel should stop ohci before doing kexec. Independant of that we can move the ohci error logging to tracepoints, so ohci emulation is silent by default. cheers, Gerd