qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
	Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH] ohci: Stop OHCI bus when PCI bus master is disabled
Date: Thu, 11 Sep 2014 12:15:46 +0200	[thread overview]
Message-ID: <1410430546.6138.9.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <54115AB9.8080700@ozlabs.ru>

  Hi,

> To be precise, it is kdump.

Ok, kdump is a different story, radically turn off all DMA is reasonable
in that case, normal driver shutdown might be unreliable after panic and
it also changes system state too much for a useful dump.

ohci (and probably others too, but without spamming the log) throwing
dma errors then is normal fallout though.  kdump kernel should be able
to bring the device back online after such an error, with your patch
applied you can't test that with qemu any more ...

> > Independant of that we can move the ohci error logging to tracepoints,
> > so ohci emulation is silent by default.
> 
> That is the other way to go, yes.

Lets do it this way please.

cheers,
  Gerd

  reply	other threads:[~2014-09-11 10:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-11  7:11 [Qemu-devel] [PATCH] ohci: Stop OHCI bus when PCI bus master is disabled Alexey Kardashevskiy
2014-09-11  7:22 ` Gerd Hoffmann
2014-09-11  8:18   ` Alexey Kardashevskiy
2014-09-11 10:15     ` Gerd Hoffmann [this message]
2014-09-11 10:30       ` Alexey Kardashevskiy
2014-09-11 10:38         ` Gerd Hoffmann
2014-09-11 11:02           ` Alexey Kardashevskiy
2014-09-12  4:09             ` Alexey Kardashevskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1410430546.6138.9.camel@nilsson.home.kraxel.org \
    --to=kraxel@redhat.com \
    --cc=agraf@suse.de \
    --cc=aik@ozlabs.ru \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).