From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54157) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XS1Pw-0004ME-Rg for qemu-devel@nongnu.org; Thu, 11 Sep 2014 06:16:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XS1Pq-0008WS-OA for qemu-devel@nongnu.org; Thu, 11 Sep 2014 06:15:56 -0400 Message-ID: <1410430546.6138.9.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Thu, 11 Sep 2014 12:15:46 +0200 In-Reply-To: <54115AB9.8080700@ozlabs.ru> References: <1410419467-9932-1-git-send-email-aik@ozlabs.ru> <1410420145.6138.7.camel@nilsson.home.kraxel.org> <54115AB9.8080700@ozlabs.ru> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] ohci: Stop OHCI bus when PCI bus master is disabled List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Alexander Graf Hi, > To be precise, it is kdump. Ok, kdump is a different story, radically turn off all DMA is reasonable in that case, normal driver shutdown might be unreliable after panic and it also changes system state too much for a useful dump. ohci (and probably others too, but without spamming the log) throwing dma errors then is normal fallout though. kdump kernel should be able to bring the device back online after such an error, with your patch applied you can't test that with qemu any more ... > > Independant of that we can move the ohci error logging to tracepoints, > > so ohci emulation is silent by default. > > That is the other way to go, yes. Lets do it this way please. cheers, Gerd