From: Gerd Hoffmann <kraxel@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Dave Airlie <airlied@redhat.com>,
virtio-dev@lists.oasis-open.org,
QEMU Developers <qemu-devel@nongnu.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>
Subject: Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file
Date: Thu, 11 Sep 2014 17:40:54 +0200 [thread overview]
Message-ID: <1410450054.8604.14.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <CAFEAcA9TZPxJi9V8EYTKvgQ_tj8VgrHTT_CRQ0=O8KhuX7tH7w@mail.gmail.com>
Hi,
> > +enum virtgpu_ctrl_type {
> > + VIRTGPU_UNDEFINED = 0,
> >
>
> This is clearly all well out of line with our
> coding style guide, which isn't a terribly good start...
Oh yea, code style is fun. This file is needed in both qemu & linux
kernel, which have different code styles. I pipe it though a sed script
already when syncing them up, weeding out the tabs. I'll go tweak my
script to fix the indent too.
cheers,
Gerd
next prev parent reply other threads:[~2014-09-11 15:41 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-11 15:09 [Qemu-devel] [PATCH 0/2] virtio-gpu: hardware specification Gerd Hoffmann
2014-09-11 15:09 ` [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file Gerd Hoffmann
2014-09-11 15:15 ` Peter Maydell
2014-09-11 15:40 ` Gerd Hoffmann [this message]
2014-09-11 15:19 ` Eric Blake
2014-09-12 10:44 ` Gerd Hoffmann
2014-09-12 12:48 ` Eric Blake
2014-09-12 12:51 ` Eric Blake
2014-09-12 13:03 ` Peter Maydell
2014-09-14 13:46 ` Michael S. Tsirkin
2014-09-14 14:04 ` Peter Maydell
2014-09-14 14:11 ` Michael S. Tsirkin
2014-09-14 14:32 ` Peter Maydell
2014-09-14 15:09 ` Michael S. Tsirkin
2014-09-14 16:11 ` Peter Maydell
2014-09-14 16:31 ` Michael S. Tsirkin
2014-09-15 10:36 ` Gerd Hoffmann
2014-09-15 10:40 ` Gerd Hoffmann
2014-09-15 10:55 ` Michael S. Tsirkin
2014-09-11 15:20 ` Peter Maydell
2014-09-11 15:43 ` Gerd Hoffmann
2014-09-11 15:53 ` Christopher Covington
2014-09-11 18:58 ` [Qemu-devel] [virtio-dev] " Paolo Bonzini
2014-09-11 15:09 ` [Qemu-devel] [PATCH 2/2] virtio-gpu/2d: add docs/specs/virtio-gpu.txt Gerd Hoffmann
2014-09-11 15:30 ` Eric Blake
2014-09-12 11:08 ` Gerd Hoffmann
2014-09-12 9:10 ` [Qemu-devel] [virtio-dev] " Stefan Hajnoczi
2014-09-12 11:38 ` Gerd Hoffmann
2014-09-12 21:14 ` Dave Airlie
2014-09-15 10:14 ` Gerd Hoffmann
2014-09-14 9:16 ` [Qemu-devel] " Michael S. Tsirkin
2014-09-14 11:05 ` [Qemu-devel] [virtio-dev] " Dave Airlie
2014-09-12 21:18 ` [Qemu-devel] [virtio-dev] [PATCH 0/2] virtio-gpu: hardware specification Dave Airlie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410450054.8604.14.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=airlied@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).