From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43684) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XS6Uj-0000aq-4Y for qemu-devel@nongnu.org; Thu, 11 Sep 2014 11:41:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XS6Ud-00057X-0m for qemu-devel@nongnu.org; Thu, 11 Sep 2014 11:41:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43998) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XS6Uc-00057J-Pf for qemu-devel@nongnu.org; Thu, 11 Sep 2014 11:41:06 -0400 Message-ID: <1410450054.8604.14.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Thu, 11 Sep 2014 17:40:54 +0200 In-Reply-To: References: <1410448173-12960-1-git-send-email-kraxel@redhat.com> <1410448173-12960-2-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Dave Airlie , virtio-dev@lists.oasis-open.org, QEMU Developers , "virtualization@lists.linux-foundation.org" Hi, > > +enum virtgpu_ctrl_type { > > + VIRTGPU_UNDEFINED = 0, > > > > This is clearly all well out of line with our > coding style guide, which isn't a terribly good start... Oh yea, code style is fun. This file is needed in both qemu & linux kernel, which have different code styles. I pipe it though a sed script already when syncing them up, weeding out the tabs. I'll go tweak my script to fix the indent too. cheers, Gerd