From: Gerd Hoffmann <kraxel@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] ui causes latest master build failure on rhel6
Date: Fri, 12 Sep 2014 08:32:23 +0200 [thread overview]
Message-ID: <1410503543.30411.1.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <20140911181704.GA29402@redhat.com>
> > pixman-0.21.8 is the oldest release which has PIXMAN_TYPE_RGBA.
> > We don't check for a minimum version.
> > RHEL-6 is probably older.
Uhm, well, it isn't (any more):
[root@rhel6 ~]# rpm -q pixman
pixman-0.26.2-5.1.el6_5.x86_64
Seems to be rebased somewhen (used to be 0.16 for RHEL-6.0 IIRC).
Looks like you should simply update your RHEL-6 machine.
> > Try 'configure --without-system-pixman' as workaround (after checking
> > out the pixman submodule).
>
> I guess but is it a must?
> We used to have this within an ifdef:
> +#if PIXMAN_VERSION >= PIXMAN_VERSION_ENCODE(0, 21, 8)
> + type = PIXMAN_TYPE_RGBA;
> +#endif
> + }
That ifdef is still there, we got new PIXMAN_TYPE_RGBA references
though.
> can't we keep system pixman working a bit longer?
I'd much prefer to raise the minimum pixman version and ditch the
#ifdefs. The common kvm case will work fine without RGBA, you may run
into trouble though when emulating bigendian guests on a little endian
host (or visa versa), because pixman will have to deal with uncommon
pixel formats then.
cheers,
Gerd
next prev parent reply other threads:[~2014-09-12 6:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-11 14:59 [Qemu-devel] ui causes latest master build failure on rhel6 Michael S. Tsirkin
2014-09-11 15:21 ` Gerd Hoffmann
2014-09-11 18:17 ` Michael S. Tsirkin
2014-09-12 6:32 ` Gerd Hoffmann [this message]
2014-09-12 14:58 ` Peter Maydell
2014-09-15 6:06 ` Gerd Hoffmann
2014-09-11 15:23 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410503543.30411.1.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).