From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35614)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1XSKPL-00031q-Pp
	for qemu-devel@nongnu.org; Fri, 12 Sep 2014 02:32:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1XSKPF-00063L-LP
	for qemu-devel@nongnu.org; Fri, 12 Sep 2014 02:32:35 -0400
Received: from mx1.redhat.com ([209.132.183.28]:53572)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1XSKPF-00063B-Df
	for qemu-devel@nongnu.org; Fri, 12 Sep 2014 02:32:29 -0400
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8C6WRPj015295
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Fri, 12 Sep 2014 02:32:28 -0400
Message-ID: <1410503543.30411.1.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Fri, 12 Sep 2014 08:32:23 +0200
In-Reply-To: <20140911181704.GA29402@redhat.com>
References: <20140911145903.GA27021@redhat.com>
	<1410448873.8604.10.camel@nilsson.home.kraxel.org>
	<20140911181704.GA29402@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] ui causes latest master build failure on rhel6
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org

> > pixman-0.21.8 is the oldest release which has PIXMAN_TYPE_RGBA.
> > We don't check for a minimum version.
> > RHEL-6 is probably older.

Uhm, well, it isn't (any more):

[root@rhel6 ~]# rpm -q pixman
pixman-0.26.2-5.1.el6_5.x86_64

Seems to be rebased somewhen (used to be 0.16 for RHEL-6.0 IIRC).
Looks like you should simply update your RHEL-6 machine.

> > Try 'configure --without-system-pixman' as workaround (after checking
> > out the pixman submodule).
> 
> I guess but is it a must?
> We used to have this within an ifdef:
> +#if PIXMAN_VERSION >= PIXMAN_VERSION_ENCODE(0, 21, 8)
> +            type = PIXMAN_TYPE_RGBA;
> +#endif
> +        }

That ifdef is still there, we got new PIXMAN_TYPE_RGBA references
though.

> can't we keep system pixman working a bit longer?

I'd much prefer to raise the minimum pixman version and ditch the
#ifdefs.  The common kvm case will work fine without RGBA, you may run
into trouble though when emulating bigendian guests on a little endian
host (or visa versa), because pixman will have to deal with uncommon
pixel formats then.

cheers,
  Gerd