From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51365) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XSOCG-0005OV-V0 for qemu-devel@nongnu.org; Fri, 12 Sep 2014 06:35:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XSOCB-0007Gt-II for qemu-devel@nongnu.org; Fri, 12 Sep 2014 06:35:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28240) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XSOCB-0007Gc-Bm for qemu-devel@nongnu.org; Fri, 12 Sep 2014 06:35:15 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8CAZEaP007124 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 12 Sep 2014 06:35:14 -0400 Received: from [10.36.116.61] (ovpn-116-61.ams2.redhat.com [10.36.116.61]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s8CAZDcl023171 for ; Fri, 12 Sep 2014 06:35:13 -0400 Message-ID: <1410518112.30411.7.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Fri, 12 Sep 2014 12:35:12 +0200 Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] checkpatch.pl false positive List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel Hi, Hooked up checkpatch to my testbuild-patch-series script. Catched some issues, now trapped into what I think is a false positive: ERROR: Macros with complex values should be enclosed in parenthesis #995: FILE: include/hw/virtio/virtio-gpu.h:99: +#define DEFINE_VIRTIO_GPU_PCI_PROPERTIES(_state) \ + DEFINE_PROP_BIT("ioeventfd", _state, flags, \ + VIRTIO_PCI_FLAG_USE_IOEVENTFD_BIT, false), \ + DEFINE_PROP_UINT32("vectors", _state, nvectors, 4) enclosing into parenthesis just isn't going to fly here as this is an array snipped, not some piece of code we could wrap into the usual "{ $code } while (0)". cheers, Gerd