From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38686) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XSTDv-0000Bq-QM for qemu-devel@nongnu.org; Fri, 12 Sep 2014 11:57:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XSTDp-0000hT-IJ for qemu-devel@nongnu.org; Fri, 12 Sep 2014 11:57:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11662) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XSTDp-0000hP-Az for qemu-devel@nongnu.org; Fri, 12 Sep 2014 11:57:17 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8CFvGFZ021739 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 12 Sep 2014 11:57:16 -0400 From: Kevin Wolf Date: Fri, 12 Sep 2014 17:56:49 +0200 Message-Id: <1410537426-9917-6-git-send-email-kwolf@redhat.com> In-Reply-To: <1410537426-9917-1-git-send-email-kwolf@redhat.com> References: <1410537426-9917-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PULL 05/22] xen: Drop redundant bdrv_close() from pci_piix3_xen_ide_unplug() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com From: Markus Armbruster drive_del() closes just fine. Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- hw/ide/piix.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/ide/piix.c b/hw/ide/piix.c index 59319eb..49e78a7 100644 --- a/hw/ide/piix.c +++ b/hw/ide/piix.c @@ -182,7 +182,6 @@ int pci_piix3_xen_ide_unplug(DeviceState *dev) if (ds) { bdrv_detach_dev(di->bdrv, ds); } - bdrv_close(di->bdrv); pci_ide->bus[di->bus].ifs[di->unit].bs = NULL; drive_del(di); } -- 1.8.3.1