qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: jsnow@redhat.com, stefanha@redhat.com, mst@redhat.com
Subject: [Qemu-devel] [RFC 00/10] AHCI Device improvements
Date: Sat, 13 Sep 2014 00:34:05 -0400	[thread overview]
Message-ID: <1410582855-21870-1-git-send-email-jsnow@redhat.com> (raw)

This patch series collects a number of fixes centered
around improving the AHCI device.

A number of them used to be tied to as-yet unposted
ahci-test patches, but I have separated them out
in order to post them standalone and collect feedback.

This series as a whole fixes a number of crashes,
bugs, and some specification issues that were a problem
mostly in unit testing, though several observable
problems with real guests are fixed by this series:

(1) Byte count after DMA completion fixes Windows 7
    hibernate as well as non-ncq BSODs.

(2) FIS decomposition fixes prevent corruption when
    reading from / writing to sectors located beyond
    the LBA28 limit.
    (Reported by Eniac Zhang <eniac@hp.com>)

(3) SDB_FIS construction issues may be partly responsible
    for unreliable NCQ operation within windows.

John Snow (10):
  ide: add is_write() macro for semantic consistency
  AHCI: Update byte count after DMA completion
  AHCI: Add PRD interrupt
  ide: Correct handling of malformed/short PRDTs
  AHCI: Rename NCQFIS structure fields
  AHCI: Fix FIS decomposition
  ide/ahci: Reorder error cases in handle_cmd
  ahci: Check cmd_fis[1] more explicitly
  ahci: factor out FIS decomposition
  AHCI: Fix SDB FIS Construction

 dma-helpers.c        |   8 ++
 hw/ide/ahci.c        | 337 +++++++++++++++++++++++++++++++--------------------
 hw/ide/ahci.h        |  51 ++++++--
 hw/ide/core.c        |  17 ++-
 hw/ide/internal.h    |   3 +
 hw/ide/pci.c         |   5 +-
 include/sysemu/dma.h |   1 +
 7 files changed, 270 insertions(+), 152 deletions(-)

-- 
1.9.3

             reply	other threads:[~2014-09-13  4:34 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-13  4:34 John Snow [this message]
2014-09-13  4:34 ` [Qemu-devel] [RFC 01/10] ide: add is_write() macro for semantic consistency John Snow
2014-09-13 12:54   ` Paolo Bonzini
2014-09-13 17:01     ` John Snow
2014-09-13  4:34 ` [Qemu-devel] [RFC 02/10] AHCI: Update byte count after DMA completion John Snow
2014-09-13 13:21   ` Paolo Bonzini
2014-09-15 20:07     ` John Snow
2014-09-16  7:54       ` Paolo Bonzini
2014-09-13  4:34 ` [Qemu-devel] [RFC 03/10] AHCI: Add PRD interrupt John Snow
2014-09-13 13:26   ` Paolo Bonzini
2014-09-13 19:50     ` Paolo Bonzini
2014-09-15 16:31       ` John Snow
2014-09-16  7:44         ` Paolo Bonzini
2014-09-15 16:13     ` John Snow
2014-09-13  4:34 ` [Qemu-devel] [RFC 04/10] ide: Correct handling of malformed/short PRDTs John Snow
2014-09-13 13:23   ` Paolo Bonzini
2014-09-13  4:34 ` [Qemu-devel] [RFC 05/10] AHCI: Rename NCQFIS structure fields John Snow
2014-09-13  4:34 ` [Qemu-devel] [RFC 06/10] AHCI: Fix FIS decomposition John Snow
2014-09-13  4:34 ` [Qemu-devel] [RFC 07/10] ide/ahci: Reorder error cases in handle_cmd John Snow
2014-09-13 13:27   ` Paolo Bonzini
2014-09-13  4:34 ` [Qemu-devel] [RFC 08/10] ahci: Check cmd_fis[1] more explicitly John Snow
2014-09-13 13:26   ` Paolo Bonzini
2014-09-13  4:34 ` [Qemu-devel] [RFC 09/10] ahci: factor out FIS decomposition John Snow
2014-09-13 13:27   ` Paolo Bonzini
2014-09-13  4:34 ` [Qemu-devel] [RFC 10/10] AHCI: Fix SDB FIS Construction John Snow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1410582855-21870-1-git-send-email-jsnow@redhat.com \
    --to=jsnow@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).